Ver código fonte

Merge pull request #1742 from sharelatex/bg-avoid-unnecessary-callback-for-emit-to-room

remove unnecessary callback on emitToRoom

GitOrigin-RevId: a34006d6f72862b1f2e0b88d20ad8003ea5b8883
Alasdair Smith 7 anos atrás
pai
commit
028c3bc94c

+ 1 - 1
services/web/app/coffee/Features/Chat/ChatController.coffee

@@ -19,7 +19,7 @@ module.exports = ChatController =
 			UserInfoManager.getPersonalInfo message.user_id, (err, user) ->
 			UserInfoManager.getPersonalInfo message.user_id, (err, user) ->
 				return next(err) if err?
 				return next(err) if err?
 				message.user = UserInfoController.formatPersonalInfo(user)
 				message.user = UserInfoController.formatPersonalInfo(user)
-				EditorRealTimeController.emitToRoom project_id, "new-chat-message", message, (err)->
+				EditorRealTimeController.emitToRoom project_id, "new-chat-message", message
 				res.send(204)
 				res.send(204)
 
 
 	getMessages: (req, res, next)->
 	getMessages: (req, res, next)->

+ 1 - 1
services/web/test/unit/coffee/Chat/ChatControllerTests.coffee

@@ -12,7 +12,7 @@ describe "ChatController", ->
 		@settings = {}
 		@settings = {}
 		@ChatApiHandler = {}
 		@ChatApiHandler = {}
 		@EditorRealTimeController =
 		@EditorRealTimeController =
-			emitToRoom:sinon.stub().callsArgWith(3)
+			emitToRoom:sinon.stub()
 		@AuthenticationController =
 		@AuthenticationController =
 			getLoggedInUserId: sinon.stub().returns(@user_id)
 			getLoggedInUserId: sinon.stub().returns(@user_id)
 		@ChatController = SandboxedModule.require modulePath, requires:
 		@ChatController = SandboxedModule.require modulePath, requires: