Merge pull request #4007 from overleaf/jpa-upgrade-underscore

[misc] upgrade underscore to the latest version

GitOrigin-RevId: 2261fa4a431d30449d55b5e6b6dc11a4b731465d

services/web/app/src/Features/Project/ProjectCreationHandler.js

@@ -224,7 +224,7 @@ async function _buildTemplate(templateName, userId, projectName) {
     year: new Date().getUTCFullYear(),
     month: MONTH_NAMES[new Date().getUTCMonth()],
   }
-  const output = _.template(template.toString(), data)
+  const output = _.template(template.toString())(data)
   return output.split('\n')
 }
 

services/web/package-lock.json

@@ -4104,6 +4104,13 @@
         "prom-client": "^11.1.3",
         "underscore": "~1.6.0",
         "yn": "^3.1.1"
+      },
+      "dependencies": {
+        "underscore": {
+          "version": "1.6.0",
+          "resolved": "https://registry.npmjs.org/underscore/-/underscore-1.6.0.tgz",
+          "integrity": "sha1-izixDKze9jM3uLJOT/htRa6lKag="
+        }
       }
     },
     "@overleaf/o-error": {
@@ -33899,9 +33906,9 @@
       }
     },
     "underscore": {
-      "version": "1.6.0",
-      "resolved": "https://registry.npmjs.org/underscore/-/underscore-1.6.0.tgz",
-      "integrity": "sha512-z4o1fvKUojIWh9XuaVLUDdf86RQiq13AC1dmHbTpoyuu+bquHms76v16CjycCbec87J7z0k//SiQVk0sMdFmpQ=="
+      "version": "1.13.1",
+      "resolved": "https://registry.npmjs.org/underscore/-/underscore-1.13.1.tgz",
+      "integrity": "sha512-hzSoAVtJF+3ZtiFX0VgfFPHEDRm7Y/QPjGyNo4TVdnDTdft3tr8hEkD25a1jC+TjTuE7tkHGKkhwCgs9dgBB2g=="
     },
     "unfetch": {
       "version": "4.1.0",

services/web/package.json

@@ -160,7 +160,7 @@
     "sanitizer": "0.1.1",
     "scroll-into-view-if-needed": "^2.2.25",
     "settings-sharelatex": "^1.2.0",
-    "underscore": "1.6.0",
+    "underscore": "^1.13.1",
     "url-parse": "^1.4.7",
     "utf-8-validate": "^5.0.2",
     "uuid": "^3.0.1",