Explorar o código

Merge pull request #34073 from overleaf/mj-remove-error-log

[web] Stop logging handled errors

GitOrigin-RevId: 7a60a576032a0dd389ef200e22c860b2ea9e8ed8
Andrew Rumble hai 4 meses
pai
achega
05895dc0dc

+ 1 - 1
services/web/app/src/Features/Uploads/DocumentConversionManager.mjs

@@ -79,7 +79,7 @@ async function convertDocumentToLaTeXZipArchive(path, userId, conversionType) {
     await pipeline(stream, outputStream)
     logger.debug({ outputPath }, 'received converted file from CLSI')
   } catch (error) {
-    logger.error({ err: error }, 'error during document conversion')
+    logger.debug({ err: error }, 'error during document conversion')
     outputStream?.destroy()
     // Make sure to clean up the output file if conversion didn't work
     await fsPromises.unlink(outputPath).catch(() => {})

+ 1 - 1
services/web/app/src/Features/Uploads/ProjectUploadController.mjs

@@ -227,7 +227,6 @@ async function importDocument(req, res, next) {
       })
     }
   } catch (error) {
-    logger.error({ error }, 'error importing document file')
     AnalyticsManager.recordEventForUserInBackground(userId, 'convert-format', {
       sourceFormat: conversionType,
       targetFormat: 'latex',
@@ -249,6 +248,7 @@ async function importDocument(req, res, next) {
         error: error.message || req.i18n.translate('upload_failed'),
       })
     }
+    logger.error({ error, userId }, 'unhandled error while importing document')
     res.status(500).json({
       success: false,
       error: req.i18n.translate('upload_failed'),