Kaynağa Gözat

Use standard promises with the http service.

Paulo Reis 9 yıl önce
ebeveyn
işleme
155f515a50
29 değiştirilmiş dosya ile 106 ekleme ve 105 silme
  1. 2 2
      services/web/public/coffee/directives/asyncForm.coffee
  2. 2 2
      services/web/public/coffee/ide/binary-files/controllers/BinaryFileController.coffee
  3. 1 1
      services/web/public/coffee/ide/chat/services/chatMessages.coffee
  4. 2 2
      services/web/public/coffee/ide/clone/controllers/CloneProjectModalController.coffee
  5. 7 7
      services/web/public/coffee/ide/file-tree/controllers/FileTreeController.coffee
  6. 3 3
      services/web/public/coffee/ide/history/HistoryManager.coffee
  7. 2 2
      services/web/public/coffee/ide/history/controllers/HistoryDiffController.coffee
  8. 2 2
      services/web/public/coffee/ide/labels/services/labels.coffee
  9. 6 6
      services/web/public/coffee/ide/pdf/controllers/PdfController.coffee
  10. 6 6
      services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee
  11. 1 1
      services/web/public/coffee/ide/settings/controllers/ProjectNameController.coffee
  12. 4 4
      services/web/public/coffee/ide/share/controllers/ShareController.coffee
  13. 9 9
      services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee
  14. 2 2
      services/web/public/coffee/ide/wordcount/controllers/WordCountModalController.coffee
  15. 4 4
      services/web/public/coffee/main/account-settings.coffee
  16. 1 1
      services/web/public/coffee/main/announcements.coffee
  17. 2 2
      services/web/public/coffee/main/annual-upgrade.coffee
  18. 2 2
      services/web/public/coffee/main/clear-sessions.coffee
  19. 2 2
      services/web/public/coffee/main/group-members.coffee
  20. 2 2
      services/web/public/coffee/main/new-subscription.coffee
  21. 6 6
      services/web/public/coffee/main/project-list/modal-controllers.coffee
  22. 3 3
      services/web/public/coffee/main/project-list/notifications-controller.coffee
  23. 3 3
      services/web/public/coffee/main/project-list/project-list.coffee
  24. 6 6
      services/web/public/coffee/main/project-list/tag-controllers.coffee
  25. 2 2
      services/web/public/coffee/main/register-users.coffee
  26. 10 10
      services/web/public/coffee/main/subscription-dashboard.coffee
  27. 4 4
      services/web/public/coffee/main/subscription/group-subscription-invite-controller.coffee
  28. 3 3
      services/web/public/coffee/main/user-details.coffee
  29. 7 6
      services/web/public/coffee/services/queued-http.coffee

+ 2 - 2
services/web/public/coffee/directives/asyncForm.coffee

@@ -28,7 +28,7 @@ define [
 					# authentication fails, we will handle it ourselves
 					# authentication fails, we will handle it ourselves
 					$http
 					$http
 						.post(element.attr('action'), formData, {disableAutoLoginRedirect: true})
 						.post(element.attr('action'), formData, {disableAutoLoginRedirect: true})
-						.success (data, status, headers, config) ->
+						.then (data, status, headers, config) ->
 							scope[attrs.name].inflight = false
 							scope[attrs.name].inflight = false
 							response.success = true
 							response.success = true
 							response.error = false
 							response.error = false
@@ -51,7 +51,7 @@ define [
 								else
 								else
 									ga('send', 'event', formName, 'success')
 									ga('send', 'event', formName, 'success')
 
 
-						.error (data, status, headers, config) ->
+						.catch (data, status, headers, config) ->
 							scope[attrs.name].inflight = false
 							scope[attrs.name].inflight = false
 							response.success = false
 							response.success = false
 							response.error = true
 							response.error = true

+ 2 - 2
services/web/public/coffee/ide/binary-files/controllers/BinaryFileController.coffee

@@ -34,7 +34,7 @@ define [
 			$scope.bibtexPreview.shouldShowDots = false
 			$scope.bibtexPreview.shouldShowDots = false
 			$scope.$apply()
 			$scope.$apply()
 			$http.get(url)
 			$http.get(url)
-				.success (data) ->
+				.then (data) ->
 					$scope.bibtexPreview.loading = false
 					$scope.bibtexPreview.loading = false
 					$scope.bibtexPreview.error = false
 					$scope.bibtexPreview.error = false
 					# show dots when payload is closs to cutoff
 					# show dots when payload is closs to cutoff
@@ -46,7 +46,7 @@ define [
 					finally
 					finally
 						$scope.bibtexPreview.data = data
 						$scope.bibtexPreview.data = data
 					$timeout($scope.setHeight, 0)
 					$timeout($scope.setHeight, 0)
-				.error (err) ->
+				.catch (err) ->
 					$scope.bibtexPreview.error = true
 					$scope.bibtexPreview.error = true
 					$scope.bibtexPreview.loading = false
 					$scope.bibtexPreview.loading = false
 
 

+ 1 - 1
services/web/public/coffee/ide/chat/services/chatMessages.coffee

@@ -47,7 +47,7 @@ define [
 			chat.state.loading = true
 			chat.state.loading = true
 			return $http
 			return $http
 				.get(url)
 				.get(url)
-				.success (messages = [])->
+				.then (messages = [])->
 					chat.state.loading = false
 					chat.state.loading = false
 					if messages.length < MESSAGE_LIMIT
 					if messages.length < MESSAGE_LIMIT
 						chat.state.atEnd = true
 						chat.state.atEnd = true

+ 2 - 2
services/web/public/coffee/ide/clone/controllers/CloneProjectModalController.coffee

@@ -23,9 +23,9 @@ define [
 			$scope.state.inflight = true
 			$scope.state.inflight = true
 			$scope.state.error = false
 			$scope.state.error = false
 			cloneProject($scope.inputs.projectName)
 			cloneProject($scope.inputs.projectName)
-				.success (data) ->
+				.then (data) ->
 					window.location = "/project/#{data.project_id}"
 					window.location = "/project/#{data.project_id}"
-				.error (body, statusCode) ->
+				.catch (body, statusCode) ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					if statusCode == 400
 					if statusCode == 400
 						$scope.state.error = { message: body }
 						$scope.state.error = { message: body }

+ 7 - 7
services/web/public/coffee/ide/file-tree/controllers/FileTreeController.coffee

@@ -63,11 +63,11 @@ define [
 				$scope.state.inflight = true
 				$scope.state.inflight = true
 				ide.fileTreeManager
 				ide.fileTreeManager
 					.createDoc(name, parent_folder)
 					.createDoc(name, parent_folder)
-					.error (e)->
-						$scope.error = e
-					.success () ->
+					.then () ->
 						$scope.state.inflight = false
 						$scope.state.inflight = false
 						$modalInstance.close()
 						$modalInstance.close()
+					.catch (e)->
+						$scope.error = e
 
 
 			$scope.cancel = () ->
 			$scope.cancel = () ->
 				$modalInstance.dismiss('cancel')
 				$modalInstance.dismiss('cancel')
@@ -95,12 +95,12 @@ define [
 				$scope.state.inflight = true
 				$scope.state.inflight = true
 				ide.fileTreeManager
 				ide.fileTreeManager
 					.createFolder(name, parent_folder)
 					.createFolder(name, parent_folder)
-					.error (e)->
-						$scope.error = e
-						$scope.state.inflight = false
-					.success () ->
+					.then () ->
 						$scope.state.inflight = false
 						$scope.state.inflight = false
 						$modalInstance.close()
 						$modalInstance.close()
+					.catch (e)->
+						$scope.error = e
+						$scope.state.inflight = false
 
 
 			$scope.cancel = () ->
 			$scope.cancel = () ->
 				$modalInstance.dismiss('cancel')
 				$modalInstance.dismiss('cancel')

+ 3 - 3
services/web/public/coffee/ide/history/HistoryManager.coffee

@@ -73,7 +73,7 @@ define [
 			@$scope.history.loading = true
 			@$scope.history.loading = true
 			@ide.$http
 			@ide.$http
 				.get(url)
 				.get(url)
-				.success (data) =>
+				.then (data) =>
 					@_loadUpdates(data.updates)
 					@_loadUpdates(data.updates)
 					@$scope.history.nextBeforeTimestamp = data.nextBeforeTimestamp
 					@$scope.history.nextBeforeTimestamp = data.nextBeforeTimestamp
 					if !data.nextBeforeTimestamp?
 					if !data.nextBeforeTimestamp?
@@ -109,12 +109,12 @@ define [
 
 
 				@ide.$http
 				@ide.$http
 					.get(url)
 					.get(url)
-					.success (data) =>
+					.then (data) =>
 						diff.loading = false
 						diff.loading = false
 						{text, highlights} = @_parseDiff(data)
 						{text, highlights} = @_parseDiff(data)
 						diff.text = text
 						diff.text = text
 						diff.highlights = highlights
 						diff.highlights = highlights
-					.error () ->
+					.catch () ->
 						diff.loading = false
 						diff.loading = false
 						diff.error = true
 						diff.error = true
 			else
 			else

+ 2 - 2
services/web/public/coffee/ide/history/controllers/HistoryDiffController.coffee

@@ -9,7 +9,7 @@ define [
 				.restoreDeletedDoc(
 				.restoreDeletedDoc(
 					$scope.history.diff.doc
 					$scope.history.diff.doc
 				)
 				)
-				.success (response) ->
+				.then (response) ->
 					$scope.history.diff.restoredDocNewId = response.doc_id
 					$scope.history.diff.restoredDocNewId = response.doc_id
 					$scope.history.diff.restoreInProgress = false
 					$scope.history.diff.restoreInProgress = false
 					$scope.history.diff.restoreDeletedSuccess = true
 					$scope.history.diff.restoreDeletedSuccess = true
@@ -37,7 +37,7 @@ define [
 			$scope.state.inflight = true
 			$scope.state.inflight = true
 			ide.historyManager
 			ide.historyManager
 				.restoreDiff(diff)
 				.restoreDiff(diff)
-				.success () ->
+				.then () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$modalInstance.close()
 					$modalInstance.close()
 					ide.editorManager.openDoc(diff.doc)
 					ide.editorManager.openDoc(diff.doc)

+ 2 - 2
services/web/public/coffee/ide/labels/services/labels.coffee

@@ -28,7 +28,7 @@ define [
 		labels.loadProjectLabelsFromServer = () ->
 		labels.loadProjectLabelsFromServer = () ->
 			$http
 			$http
 				.get("/project/#{window.project_id}/labels")
 				.get("/project/#{window.project_id}/labels")
-				.success (data) ->
+				.then (data) ->
 					if data.projectLabels
 					if data.projectLabels
 						for docId, docLabels of data.projectLabels
 						for docId, docLabels of data.projectLabels
 							state.documents[docId] = docLabels
 							state.documents[docId] = docLabels
@@ -39,6 +39,6 @@ define [
 					"/project/#{window.project_id}/doc/#{docId}/labels",
 					"/project/#{window.project_id}/doc/#{docId}/labels",
 					{_csrf: window.csrfToken}
 					{_csrf: window.csrfToken}
 				)
 				)
-				.success (data) ->
+				.then (data) ->
 
 
 		return labels
 		return labels

+ 6 - 6
services/web/public/coffee/ide/pdf/controllers/PdfController.coffee

@@ -385,11 +385,11 @@ define [
 			options.rootDocOverride_id = getRootDocOverride_id()
 			options.rootDocOverride_id = getRootDocOverride_id()
 
 
 			sendCompileRequest(options)
 			sendCompileRequest(options)
-				.success (data) ->
+				.then (data) ->
 					$scope.pdf.view = "pdf"
 					$scope.pdf.view = "pdf"
 					$scope.pdf.compiling = false
 					$scope.pdf.compiling = false
 					parseCompileResponse(data)
 					parseCompileResponse(data)
-				.error (err, status) ->
+				.catch (err, status) ->
 					if status == 429
 					if status == 429
 						$scope.pdf.rateLimited = true
 						$scope.pdf.rateLimited = true
 					$scope.pdf.compiling = false
 					$scope.pdf.compiling = false
@@ -514,9 +514,9 @@ define [
 							clsiserverid:ide.clsiServerId
 							clsiserverid:ide.clsiServerId
 						}
 						}
 					})
 					})
-					.success (data) ->
+					.then (data) ->
 						deferred.resolve(data.pdf or [])
 						deferred.resolve(data.pdf or [])
-					.error (error) ->
+					.catch (error) ->
 						deferred.reject(error)
 						deferred.reject(error)
 
 
 				return deferred.promise
 				return deferred.promise
@@ -559,12 +559,12 @@ define [
 							clsiserverid:ide.clsiServerId
 							clsiserverid:ide.clsiServerId
 						}
 						}
 					})
 					})
-					.success (data) ->
+					.then (data) ->
 						if data.code? and data.code.length > 0
 						if data.code? and data.code.length > 0
 							doc = ide.fileTreeManager.findEntityByPath(data.code[0].file)
 							doc = ide.fileTreeManager.findEntityByPath(data.code[0].file)
 							return if !doc?
 							return if !doc?
 							deferred.resolve({doc: doc, line: data.code[0].line})
 							deferred.resolve({doc: doc, line: data.code[0].line})
-					.error (error) ->
+					.catch (error) ->
 						deferred.reject(error)
 						deferred.reject(error)
 
 
 				return deferred.promise
 				return deferred.promise

+ 6 - 6
services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee

@@ -188,7 +188,7 @@ define [
 		
 		
 		refreshRanges = () ->
 		refreshRanges = () ->
 			$http.get "/project/#{$scope.project_id}/ranges"
 			$http.get "/project/#{$scope.project_id}/ranges"
-				.success (docs) ->
+				.then (docs) ->
 					for doc in docs
 					for doc in docs
 						if !$scope.reviewPanel.overview.docsCollapsedState[doc.id]?
 						if !$scope.reviewPanel.overview.docsCollapsedState[doc.id]?
 							$scope.reviewPanel.overview.docsCollapsedState[doc.id] = false
 							$scope.reviewPanel.overview.docsCollapsedState[doc.id] = false
@@ -438,7 +438,7 @@ define [
 			thread.submitting = true
 			thread.submitting = true
 			$scope.$broadcast "comment:add", thread_id, offset, length
 			$scope.$broadcast "comment:add", thread_id, offset, length
 			$http.post("/project/#{$scope.project_id}/thread/#{thread_id}/messages", {content, _csrf: window.csrfToken})
 			$http.post("/project/#{$scope.project_id}/thread/#{thread_id}/messages", {content, _csrf: window.csrfToken})
-				.error (error) ->
+				.catch (error) ->
 					ide.showGenericMessageModal("Error submitting comment", "Sorry, there was a problem submitting your comment")
 					ide.showGenericMessageModal("Error submitting comment", "Sorry, there was a problem submitting your comment")
 			$scope.$broadcast "editor:clearSelection"
 			$scope.$broadcast "editor:clearSelection"
 			$timeout () ->
 			$timeout () ->
@@ -458,7 +458,7 @@ define [
 			thread_id = entry.thread_id
 			thread_id = entry.thread_id
 			content   = entry.replyContent
 			content   = entry.replyContent
 			$http.post("/project/#{$scope.project_id}/thread/#{thread_id}/messages", {content, _csrf: window.csrfToken})
 			$http.post("/project/#{$scope.project_id}/thread/#{thread_id}/messages", {content, _csrf: window.csrfToken})
-				.error (error) ->
+				.catch (error) ->
 					ide.showGenericMessageModal("Error submitting comment", "Sorry, there was a problem submitting your comment")
 					ide.showGenericMessageModal("Error submitting comment", "Sorry, there was a problem submitting your comment")
 			
 			
 			trackingMetadata =
 			trackingMetadata =
@@ -598,7 +598,7 @@ define [
 			_refreshingRangeUsers = true
 			_refreshingRangeUsers = true
 
 
 			$http.get "/project/#{$scope.project_id}/changes/users"
 			$http.get "/project/#{$scope.project_id}/changes/users"
-				.success (users) ->
+				.then (users) ->
 					_refreshingRangeUsers = false
 					_refreshingRangeUsers = false
 					$scope.users = {}
 					$scope.users = {}
 					# Always include ourself, since if we submit an op, we might need to display info
 					# Always include ourself, since if we submit an op, we might need to display info
@@ -608,7 +608,7 @@ define [
 					for user in users
 					for user in users
 						if user.id?
 						if user.id?
 							$scope.users[user.id] = formatUser(user)
 							$scope.users[user.id] = formatUser(user)
-				.error () ->
+				.catch () ->
 					_refreshingRangeUsers = false
 					_refreshingRangeUsers = false
 
 
 		_threadsLoaded = false
 		_threadsLoaded = false
@@ -619,7 +619,7 @@ define [
 			_threadsLoaded = true
 			_threadsLoaded = true
 			$scope.reviewPanel.loadingThreads = true
 			$scope.reviewPanel.loadingThreads = true
 			$http.get "/project/#{$scope.project_id}/threads"
 			$http.get "/project/#{$scope.project_id}/threads"
-				.success (threads) ->
+				.then (threads) ->
 					$scope.reviewPanel.loadingThreads = false
 					$scope.reviewPanel.loadingThreads = false
 					for thread_id, _ of $scope.reviewPanel.resolvedThreadIds
 					for thread_id, _ of $scope.reviewPanel.resolvedThreadIds
 						delete $scope.reviewPanel.resolvedThreadIds[thread_id]
 						delete $scope.reviewPanel.resolvedThreadIds[thread_id]

+ 1 - 1
services/web/public/coffee/ide/settings/controllers/ProjectNameController.coffee

@@ -24,7 +24,7 @@ define [
 			oldName = $scope.project.name
 			oldName = $scope.project.name
 			$scope.project.name = newName
 			$scope.project.name = newName
 			settings.saveProjectSettings({name: $scope.project.name})
 			settings.saveProjectSettings({name: $scope.project.name})
-				.error (response, statusCode) ->
+				.catch (response, statusCode) ->
 					$scope.project.name = oldName
 					$scope.project.name = oldName
 					if statusCode == 400
 					if statusCode == 400
 						ide.showGenericMessageModal("Error renaming project", response)
 						ide.showGenericMessageModal("Error renaming project", response)

+ 4 - 4
services/web/public/coffee/ide/share/controllers/ShareController.coffee

@@ -15,16 +15,16 @@ define [
 			ide.socket.on 'project:membership:changed', (data) =>
 			ide.socket.on 'project:membership:changed', (data) =>
 				if data.members
 				if data.members
 					projectMembers.getMembers()
 					projectMembers.getMembers()
-						.success (responseData) =>
+						.then (responseData) =>
 							if responseData.members
 							if responseData.members
 								$scope.project.members = responseData.members
 								$scope.project.members = responseData.members
-						.error (responseDate) =>
+						.catch (responseDate) =>
 							console.error "Error fetching members for project"
 							console.error "Error fetching members for project"
 				if data.invites
 				if data.invites
 					projectInvites.getInvites()
 					projectInvites.getInvites()
-						.success (responseData) =>
+						.then (responseData) =>
 							if responseData.invites
 							if responseData.invites
 								$scope.project.invites = responseData.invites
 								$scope.project.invites = responseData.invites
-						.error (responseDate) =>
+						.catch (responseDate) =>
 							console.error "Error fetching invites for project"
 							console.error "Error fetching invites for project"
 	]
 	]

+ 9 - 9
services/web/public/coffee/ide/share/controllers/ShareProjectModalController.coffee

@@ -34,7 +34,7 @@ define [
 		$scope.autocompleteContacts = []
 		$scope.autocompleteContacts = []
 		do loadAutocompleteUsers = () ->
 		do loadAutocompleteUsers = () ->
 			$http.get "/user/contacts"
 			$http.get "/user/contacts"
-				.success (data) ->
+				.then (data) ->
 					$scope.autocompleteContacts = data.contacts or []
 					$scope.autocompleteContacts = data.contacts or []
 					for contact in $scope.autocompleteContacts
 					for contact in $scope.autocompleteContacts
 						if contact.type == "user"
 						if contact.type == "user"
@@ -102,7 +102,7 @@ define [
 						request = projectInvites.sendInvite(email, $scope.inputs.privileges)
 						request = projectInvites.sendInvite(email, $scope.inputs.privileges)
 
 
 					request
 					request
-						.success (data) ->
+						.then (data) ->
 							if data.error
 							if data.error
 								$scope.state.error = true
 								$scope.state.error = true
 								$scope.state.errorReason = "#{data.error}"
 								$scope.state.errorReason = "#{data.error}"
@@ -125,7 +125,7 @@ define [
 								# with new collaborator information.
 								# with new collaborator information.
 								addNextMember()
 								addNextMember()
 							, 0
 							, 0
-						.error () ->
+						.catch () ->
 							$scope.state.inflight = false
 							$scope.state.inflight = false
 							$scope.state.error = true
 							$scope.state.error = true
 							$scope.state.errorReason = null
 							$scope.state.errorReason = null
@@ -137,12 +137,12 @@ define [
 			$scope.state.inflight = true
 			$scope.state.inflight = true
 			projectMembers
 			projectMembers
 				.removeMember(member)
 				.removeMember(member)
-				.success () ->
+				.then () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					index = $scope.project.members.indexOf(member)
 					index = $scope.project.members.indexOf(member)
 					return if index == -1
 					return if index == -1
 					$scope.project.members.splice(index, 1)
 					$scope.project.members.splice(index, 1)
-				.error () ->
+				.catch () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$scope.state.error = "Sorry, something went wrong :("
 					$scope.state.error = "Sorry, something went wrong :("
 
 
@@ -151,12 +151,12 @@ define [
 			$scope.state.inflight = true
 			$scope.state.inflight = true
 			projectInvites
 			projectInvites
 				.revokeInvite(invite._id)
 				.revokeInvite(invite._id)
-				.success () ->
+				.then () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					index = $scope.project.invites.indexOf(invite)
 					index = $scope.project.invites.indexOf(invite)
 					return if index == -1
 					return if index == -1
 					$scope.project.invites.splice(index, 1)
 					$scope.project.invites.splice(index, 1)
-				.error () ->
+				.catch () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$scope.state.error = "Sorry, something went wrong :("
 					$scope.state.error = "Sorry, something went wrong :("
 
 
@@ -165,10 +165,10 @@ define [
 			$scope.state.inflight = true
 			$scope.state.inflight = true
 			projectInvites
 			projectInvites
 				.resendInvite(invite._id)
 				.resendInvite(invite._id)
-				.success () ->
+				.then () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					event.target.blur()
 					event.target.blur()
-				.error () ->
+				.catch () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$scope.state.error = "Sorry, something went wrong resending the invite :("
 					$scope.state.error = "Sorry, something went wrong resending the invite :("
 					event.target.blur()
 					event.target.blur()

+ 2 - 2
services/web/public/coffee/ide/wordcount/controllers/WordCountModalController.coffee

@@ -11,10 +11,10 @@ define [
 			params:
 			params:
 				clsiserverid:ide.clsiServerId
 				clsiserverid:ide.clsiServerId
 		$http opts
 		$http opts
-			.success (data) ->
+			.then (data) ->
 				$scope.status.loading = false
 				$scope.status.loading = false
 				$scope.data = data.texcount
 				$scope.data = data.texcount
-			.error () ->
+			.catch () ->
 				$scope.status.error = true
 				$scope.status.error = true
 
 
 		$scope.cancel = () ->
 		$scope.cancel = () ->

+ 4 - 4
services/web/public/coffee/main/account-settings.coffee

@@ -12,10 +12,10 @@ define [
 					headers:
 					headers:
 						"X-CSRF-Token": window.csrfToken
 						"X-CSRF-Token": window.csrfToken
 				})
 				})
-				.success () ->
+				.then () ->
 					$scope.unsubscribing = false
 					$scope.unsubscribing = false
 					$scope.subscribed = false
 					$scope.subscribed = false
-				.error () ->
+				.catch () ->
 					$scope.unsubscribing = true
 					$scope.unsubscribing = true
 
 
 		$scope.deleteAccount = () ->
 		$scope.deleteAccount = () ->
@@ -59,7 +59,7 @@ define [
 							password: $scope.state.password
 							password: $scope.state.password
 						disableAutoLoginRedirect: true # we want to handle errors ourselves
 						disableAutoLoginRedirect: true # we want to handle errors ourselves
 					})
 					})
-					.success () ->
+					.then () ->
 						$modalInstance.close()
 						$modalInstance.close()
 						$scope.state.inflight = false
 						$scope.state.inflight = false
 						$scope.state.error = false
 						$scope.state.error = false
@@ -69,7 +69,7 @@ define [
 								window.location = "/login"
 								window.location = "/login"
 							, 1000
 							, 1000
 						)
 						)
-					.error (data, status) ->
+					.catch (data, status) ->
 						$scope.state.inflight = false
 						$scope.state.inflight = false
 						if status == 403
 						if status == 403
 							$scope.state.invalidCredentials = true
 							$scope.state.invalidCredentials = true

+ 1 - 1
services/web/public/coffee/main/announcements.coffee

@@ -8,7 +8,7 @@ define [
 			newItems: 0
 			newItems: 0
 		
 		
 		refreshAnnouncements = ->
 		refreshAnnouncements = ->
-			$http.get("/announcements").success (announcements) ->
+			$http.get("/announcements").then (announcements) ->
 				$scope.announcements = announcements
 				$scope.announcements = announcements
 				$scope.ui.newItems = _.filter(announcements, (announcement) -> !announcement.read).length
 				$scope.ui.newItems = _.filter(announcements, (announcement) -> !announcement.read).length
 				
 				

+ 2 - 2
services/web/public/coffee/main/annual-upgrade.coffee

@@ -22,7 +22,7 @@ define [
 
 
 
 
 			$http.post(MESSAGES_URL, body)
 			$http.post(MESSAGES_URL, body)
-				.success ->
+				.then ->
 					$scope.upgradeComplete = true
 					$scope.upgradeComplete = true
-				.error ->
+				.catch ->
 					console.log "something went wrong changing plan"
 					console.log "something went wrong changing plan"

+ 2 - 2
services/web/public/coffee/main/clear-sessions.coffee

@@ -11,10 +11,10 @@ define [
 		$scope.clearSessions = () ->
 		$scope.clearSessions = () ->
 			console.log ">> clearing all sessions"
 			console.log ">> clearing all sessions"
 			$http({method: 'POST', url: "/user/sessions/clear", headers: {'X-CSRF-Token': window.csrfToken}})
 			$http({method: 'POST', url: "/user/sessions/clear", headers: {'X-CSRF-Token': window.csrfToken}})
-			.success () ->
+			.then () ->
 				$scope.state.otherSessions = []
 				$scope.state.otherSessions = []
 				$scope.state.error = false
 				$scope.state.error = false
 				$scope.state.success = true
 				$scope.state.success = true
-			.error () ->
+			.catch () ->
 				$scope.state.error = true
 				$scope.state.error = true
 	]
 	]

+ 2 - 2
services/web/public/coffee/main/group-members.coffee

@@ -26,7 +26,7 @@ define [
 						email: email,
 						email: email,
 						_csrf: window.csrfToken
 						_csrf: window.csrfToken
 					})
 					})
-					.success (data) ->
+					.then (data) ->
 						$scope.users.push data.user if data.user?
 						$scope.users.push data.user if data.user?
 						$scope.inputs.emails = ""
 						$scope.inputs.emails = ""
 
 
@@ -43,7 +43,7 @@ define [
 						headers:
 						headers:
 							"X-Csrf-Token": window.csrfToken
 							"X-Csrf-Token": window.csrfToken
 					})
 					})
-						.success () ->
+						.then () ->
 							index = $scope.users.indexOf(user)
 							index = $scope.users.indexOf(user)
 							return if index == -1
 							return if index == -1
 							$scope.users.splice(index, 1)
 							$scope.users.splice(index, 1)

+ 2 - 2
services/web/public/coffee/main/new-subscription.coffee

@@ -162,10 +162,10 @@ define [
 
 
 
 
 				$http.post("/user/subscription/create", postData)
 				$http.post("/user/subscription/create", postData)
-					.success (data, status, headers)->
+					.then (data, status, headers)->
 						event_tracking.sendMB "subscription-submission-success"
 						event_tracking.sendMB "subscription-submission-success"
 						window.location.href = "/user/subscription/thank-you"
 						window.location.href = "/user/subscription/thank-you"
-					.error (data, status, headers)->
+					.catch (data, status, headers)->
 						$scope.processing = false
 						$scope.processing = false
 						$scope.genericError = "Something went wrong processing the request"
 						$scope.genericError = "Something went wrong processing the request"
 
 

+ 6 - 6
services/web/public/coffee/main/project-list/modal-controllers.coffee

@@ -19,11 +19,11 @@ define [
 			$scope.state.error = false
 			$scope.state.error = false
 			$scope
 			$scope
 				.renameProject(project, $scope.inputs.projectName)
 				.renameProject(project, $scope.inputs.projectName)
-				.success () ->
+				.then () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$scope.state.error = false
 					$scope.state.error = false
 					$modalInstance.close()
 					$modalInstance.close()
-				.error (body, statusCode) ->
+				.catch (body, statusCode) ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					if statusCode == 400
 					if statusCode == 400
 						$scope.state.error = { message: body }
 						$scope.state.error = { message: body }
@@ -49,11 +49,11 @@ define [
 			$scope.state.inflight = true
 			$scope.state.inflight = true
 			$scope
 			$scope
 				.cloneProject(project, $scope.inputs.projectName)
 				.cloneProject(project, $scope.inputs.projectName)
-				.success () ->
+				.then () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$scope.state.error = false
 					$scope.state.error = false
 					$modalInstance.close()
 					$modalInstance.close()
-				.error (body, statusCode) ->
+				.catch (body, statusCode) ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					if statusCode == 400
 					if statusCode == 400
 						$scope.state.error = { message: body }
 						$scope.state.error = { message: body }
@@ -80,11 +80,11 @@ define [
 			$scope.state.error = false
 			$scope.state.error = false
 			$scope
 			$scope
 				.createProject($scope.inputs.projectName, template)
 				.createProject($scope.inputs.projectName, template)
-				.success (data) ->
+				.then (data) ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$scope.state.error = false
 					$scope.state.error = false
 					$modalInstance.close(data.project_id)
 					$modalInstance.close(data.project_id)
-				.error (body, statusCode) ->
+				.catch (body, statusCode) ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					if statusCode == 400
 					if statusCode == 400
 						$scope.state.error = { message: body }
 						$scope.state.error = { message: body }

+ 3 - 3
services/web/public/coffee/main/project-list/notifications-controller.coffee

@@ -13,7 +13,7 @@ define [
 				headers:
 				headers:
 					"X-Csrf-Token": window.csrfToken
 					"X-Csrf-Token": window.csrfToken
 			})
 			})
-				.success (data) ->
+				.then (data) ->
 					notification.hide = true
 					notification.hide = true
 					
 					
 	App.controller "ProjectInviteNotificationController", ($scope, $http) ->
 	App.controller "ProjectInviteNotificationController", ($scope, $http) ->
@@ -30,9 +30,9 @@ define [
 					"X-Csrf-Token": window.csrfToken
 					"X-Csrf-Token": window.csrfToken
 					"X-Requested-With": "XMLHttpRequest"
 					"X-Requested-With": "XMLHttpRequest"
 			})
 			})
-				.success () ->
+				.then () ->
 					$scope.notification.inflight = false
 					$scope.notification.inflight = false
 					$scope.notification.accepted = true
 					$scope.notification.accepted = true
-				.error () ->
+				.catch () ->
 					$scope.notification.inflight = false
 					$scope.notification.inflight = false
 					$scope.notification.error = true
 					$scope.notification.error = true

+ 3 - 3
services/web/public/coffee/main/project-list/project-list.coffee

@@ -262,7 +262,7 @@ define [
 					projectName: name
 					projectName: name
 					template: template
 					template: template
 				})
 				})
-				.success((data, status, headers, config) ->
+				.then((data, status, headers, config) ->
 					$scope.projects.push {
 					$scope.projects.push {
 						name: name
 						name: name
 						_id: data.project_id
 						_id: data.project_id
@@ -291,7 +291,7 @@ define [
 				newProjectName: newName,
 				newProjectName: newName,
 				_csrf: window.csrfToken
 				_csrf: window.csrfToken
 			}
 			}
-				.success () ->
+				.then () ->
 					project.name = newName
 					project.name = newName
 
 
 		$scope.openRenameProjectModal = () ->
 		$scope.openRenameProjectModal = () ->
@@ -313,7 +313,7 @@ define [
 					_csrf: window.csrfToken
 					_csrf: window.csrfToken
 					projectName: cloneName
 					projectName: cloneName
 				})
 				})
-				.success((data, status, headers, config) ->
+				.then((data, status, headers, config) ->
 					$scope.projects.push {
 					$scope.projects.push {
 						name: cloneName
 						name: cloneName
 						id: data.project_id
 						id: data.project_id

+ 6 - 6
services/web/public/coffee/main/project-list/tag-controllers.coffee

@@ -94,10 +94,10 @@ define [
 					_csrf: window.csrfToken,
 					_csrf: window.csrfToken,
 					name: name
 					name: name
 				}
 				}
-				.success (data, status, headers, config) ->
+				.then (data, status, headers, config) ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$modalInstance.close(data)
 					$modalInstance.close(data)
-				.error () ->
+				.catch () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$scope.state.error = true
 					$scope.state.error = true
 
 
@@ -126,10 +126,10 @@ define [
 					_csrf: window.csrfToken,
 					_csrf: window.csrfToken,
 					name: name
 					name: name
 				}
 				}
-				.success () ->
+				.then () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$modalInstance.close(name)
 					$modalInstance.close(name)
-				.error () ->
+				.catch () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$scope.state.error = true
 					$scope.state.error = true
 
 
@@ -151,10 +151,10 @@ define [
 				headers:
 				headers:
 					"X-CSRF-Token": window.csrfToken
 					"X-CSRF-Token": window.csrfToken
 			})
 			})
-				.success () ->
+				.then () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$modalInstance.close()
 					$modalInstance.close()
-				.error () ->
+				.catch () ->
 					$scope.state.inflight = false
 					$scope.state.inflight = false
 					$scope.state.error = true
 					$scope.state.error = true
 		
 		

+ 2 - 2
services/web/public/coffee/main/register-users.coffee

@@ -25,8 +25,8 @@ define [
 						email: email,
 						email: email,
 						_csrf: window.csrfToken
 						_csrf: window.csrfToken
 					})
 					})
-					.success (user) ->
+					.then (user) ->
 						$scope.users.push user
 						$scope.users.push user
 						$scope.inputs.emails = ""
 						$scope.inputs.emails = ""
-					.error () ->
+					.catch () ->
 						$scope.error = true
 						$scope.error = true

+ 10 - 10
services/web/public/coffee/main/subscription-dashboard.coffee

@@ -68,9 +68,9 @@ define [
 			$scope.inflight = true
 			$scope.inflight = true
 
 
 			$http.post("#{SUBSCRIPTION_URL}?origin=confirmChangePlan", body)
 			$http.post("#{SUBSCRIPTION_URL}?origin=confirmChangePlan", body)
-				.success ->
+				.then ->
 					location.reload()
 					location.reload()
-				.error ->
+				.catch ->
 					console.log "something went wrong changing plan"
 					console.log "something went wrong changing plan"
 
 
 		$scope.cancel = () ->
 		$scope.cancel = () ->
@@ -83,9 +83,9 @@ define [
 				url: "/subscription/group/user",
 				url: "/subscription/group/user",
 				method: "DELETE",
 				method: "DELETE",
 				params: {admin_user_id: $scope.admin_id, _csrf: window.csrfToken}
 				params: {admin_user_id: $scope.admin_id, _csrf: window.csrfToken}
-			}).success ->
+			}).then ->
 				location.reload()
 				location.reload()
-			.error ->
+			.catch ->
 				console.log "something went wrong changing plan"
 				console.log "something went wrong changing plan"
 
 
 		$scope.cancel = () ->
 		$scope.cancel = () ->
@@ -141,9 +141,9 @@ define [
 				_csrf : window.csrfToken
 				_csrf : window.csrfToken
 			$scope.inflight = true
 			$scope.inflight = true
 			$http.post("#{SUBSCRIPTION_URL}?origin=downgradeToStudent", body)
 			$http.post("#{SUBSCRIPTION_URL}?origin=downgradeToStudent", body)
-				.success ->
+				.then ->
 					location.reload()
 					location.reload()
-				.error ->
+				.catch ->
 					console.log "something went wrong changing plan"
 					console.log "something went wrong changing plan"
 
 
 		$scope.cancelSubscription = ->
 		$scope.cancelSubscription = ->
@@ -152,9 +152,9 @@ define [
 
 
 			$scope.inflight = true
 			$scope.inflight = true
 			$http.post("/user/subscription/cancel", body)
 			$http.post("/user/subscription/cancel", body)
-				.success ->
+				.then ->
 					location.reload()
 					location.reload()
-				.error ->
+				.catch ->
 					console.log "something went wrong changing plan"
 					console.log "something went wrong changing plan"
 
 
 
 
@@ -176,7 +176,7 @@ define [
 				_csrf : window.csrfToken
 				_csrf : window.csrfToken
 			$scope.inflight = true
 			$scope.inflight = true
 			$http.put("/user/subscription/extend", body)
 			$http.put("/user/subscription/extend", body)
-				.success ->
+				.then ->
 					location.reload()
 					location.reload()
-				.error ->
+				.catch ->
 					console.log "something went wrong changing plan"
 					console.log "something went wrong changing plan"

+ 4 - 4
services/web/public/coffee/main/subscription/group-subscription-invite-controller.coffee

@@ -16,19 +16,19 @@ define [
 		$scope.cancelSubscription = ->
 		$scope.cancelSubscription = ->
 			$scope.inflight = true
 			$scope.inflight = true
 			request = $http.post "/user/subscription/cancel", {_csrf:window.csrfToken}
 			request = $http.post "/user/subscription/cancel", {_csrf:window.csrfToken}
-			request.success (data, status)->
+			request.then (data, status)->
 				$scope.inflight = false
 				$scope.inflight = false
 				$scope.view = "groupSubscriptionInvite"
 				$scope.view = "groupSubscriptionInvite"
-			request.error (data, status)->
+			request.catch (data, status)->
 				console.log "the request failed"					
 				console.log "the request failed"					
 
 
 		$scope.joinGroup = ->
 		$scope.joinGroup = ->
 			$scope.view = "requestSent"
 			$scope.view = "requestSent"
 			$scope.inflight = true
 			$scope.inflight = true
 			request = $http.post "/user/subscription/#{group_subscription_id}/group/begin-join", {_csrf:window.csrfToken}
 			request = $http.post "/user/subscription/#{group_subscription_id}/group/begin-join", {_csrf:window.csrfToken}
-			request.success (data, status)->
+			request.then (data, status)->
 				$scope.inflight = false
 				$scope.inflight = false
 				if status != 200 # assume request worked
 				if status != 200 # assume request worked
 					$scope.requestSent = false
 					$scope.requestSent = false
-			request.error (data, status)->
+			request.catch (data, status)->
 				console.log "the request failed"
 				console.log "the request failed"

+ 3 - 3
services/web/public/coffee/main/user-details.coffee

@@ -7,7 +7,7 @@ define [
 
 
 	App.controller "UserProfileController", ($scope, $modal, $http)->
 	App.controller "UserProfileController", ($scope, $modal, $http)->
 		$scope.institutions = []
 		$scope.institutions = []
-		$http.get("/user/personal_info").success (data)->
+		$http.get("/user/personal_info").then (data)->
 			$scope.userInfoForm =
 			$scope.userInfoForm =
 				first_name: data.first_name || ""
 				first_name: data.first_name || ""
 				last_name: data.last_name || ""
 				last_name: data.last_name || ""
@@ -43,8 +43,8 @@ define [
 
 
 		sendUpdate = ->
 		sendUpdate = ->
 			request = $http.post "/user/settings", $scope.userInfoForm
 			request = $http.post "/user/settings", $scope.userInfoForm
-			request.success (data, status)->
-			request.error (data, status)->
+			request.then (data, status)->
+			request.catch (data, status)->
 				console.log "the request failed"
 				console.log "the request failed"
 
 
 		$scope.updateInstitutionsList = (inputVal)->
 		$scope.updateInstitutionsList = (inputVal)->

+ 7 - 6
services/web/public/coffee/services/queued-http.coffee

@@ -11,10 +11,10 @@ define [
 			if doRequest?
 			if doRequest?
 				inflight = true
 				inflight = true
 				doRequest()
 				doRequest()
-					.success () ->
+					.then () ->
 						inflight = false
 						inflight = false
 						processPendingRequests()
 						processPendingRequests()
-					.error () ->
+					.catch () ->
 						inflight = false
 						inflight = false
 						processPendingRequests()
 						processPendingRequests()
 
 
@@ -26,20 +26,21 @@ define [
 			errorCallbacks = []
 			errorCallbacks = []
 
 
 			# Adhere to the $http promise conventions
 			# Adhere to the $http promise conventions
-			promise.success = (callback) ->
+			promise.then = (callback, errCallback) ->
 				successCallbacks.push callback
 				successCallbacks.push callback
+				errorCallbacks.push errCallback if errCallback?
 				return promise
 				return promise
 
 
-			promise.error = (callback) ->
+			promise.catch = (callback) ->
 				errorCallbacks.push callback
 				errorCallbacks.push callback
 				return promise
 				return promise
 
 
 			doRequest = () ->
 			doRequest = () ->
 				$http(args...)
 				$http(args...)
-					.success (args...) ->
+					.then (args...) ->
 						for cb in successCallbacks
 						for cb in successCallbacks
 							cb(args...)
 							cb(args...)
-					.error (args...) ->
+					.catch (args...) ->
 						for cb in errorCallbacks
 						for cb in errorCallbacks
 							cb(args...)
 							cb(args...)