Kaynağa Gözat

removed req.session.destorys from endpoints now on the api router which are not needed

Henry Oswald 11 yıl önce
ebeveyn
işleme
15a57f5dc4

+ 0 - 1
services/web/app/coffee/Features/Collaborators/CollaboratorsController.coffee

@@ -4,7 +4,6 @@ EditorController = require "../Editor/EditorController"
 
 module.exports = CollaboratorsController =
 	getCollaborators: (req, res, next = (error) ->) ->
-		req.session.destroy()
 		ProjectGetter.getProject req.params.Project_id, { owner_ref: true, collaberator_refs: true, readOnly_refs: true}, (error, project) ->
 			return next(error) if error?
 			ProjectGetter.populateProjectWithUsers project, (error, project) ->

+ 0 - 2
services/web/app/coffee/Features/Documents/DocumentController.coffee

@@ -15,7 +15,6 @@ module.exports =
 			res.send JSON.stringify {
 				lines: lines
 			}
-			req.session.destroy()
 
 	setDocument: (req, res, next = (error) ->) ->
 		project_id = req.params.Project_id
@@ -28,7 +27,6 @@ module.exports =
 				return next(error)
 			logger.log doc_id:doc_id, project_id:project_id, "finished receiving set document request from api (docupdater)"
 			res.send 200
-			req.session.destroy()
 
 		
 		

+ 0 - 4
services/web/app/coffee/Features/ThirdPartyDataStore/TpdsController.coffee

@@ -21,7 +21,6 @@ module.exports =
 			else
 				logger.log user_id:user_id, filePath:filePath, projectName:projectName, "telling tpds update has been processed"
 				res.send 200
-			req.session.destroy()
 
 
 	deleteUpdate: (req, res)->
@@ -36,7 +35,6 @@ module.exports =
 			else
 				logger.log user_id:user_id, filePath:filePath, projectName:projectName, "telling tpds delete has been processed"
 				res.send 200
-			req.session.destroy()
 	
 	# updateProjectContents and deleteProjectContents are used by GitHub. The project_id is known so we 
 	# can skip right ahead to creating/updating/deleting the file. These methods will not ignore noisy
@@ -50,7 +48,6 @@ module.exports =
 		UpdateMerger.mergeUpdate project_id, path, req, source, (error) ->
 			return next(error) if error?
 			res.send(200)
-			req.session.destroy()
 			
 	deleteProjectContents: (req, res, next = (error) ->) ->
 		{project_id} = req.params
@@ -60,7 +57,6 @@ module.exports =
 		UpdateMerger.deleteUpdate project_id, path, source, (error) ->
 			return next(error) if error?
 			res.send(200)
-			req.session.destroy()
 
 	parseParams: parseParams = (req)->
 		path = req.params[0]

+ 1 - 1
services/web/app/coffee/Features/User/UserController.coffee

@@ -20,7 +20,7 @@ module.exports =
 		user_id = req.session.user._id
 		UserDeleter.deleteUser user_id, (err)->
 			if !err?
-				req.session.destroy()
+				req.session?.destroy()
 			res.send(200)
 
 	unsubscribe: (req, res)->

+ 1 - 2
services/web/app/coffee/Features/User/UserInfoController.coffee

@@ -9,7 +9,7 @@ module.exports = UserController =
 		# this is funcky as hell, we don't use the current session to get the user
 		# we use the auth token, actually destroying session from the chat api request
 		if req.query?.auth_token?
-			req.session.destroy() 
+			req.session?.destroy() 
 		logger.log user: req.user, "reciving request for getting logged in users personal info"
 		return next(new Error("User is not logged in")) if !req.user?
 		UserGetter.getUser req.user._id, {
@@ -26,7 +26,6 @@ module.exports = UserController =
 			return next(error) if error?
 			return res.send(404) if !user?
 			UserController.sendFormattedPersonalInfo(user, res, next)
-			req.session.destroy()
 
 	sendFormattedPersonalInfo: (user, res, next = (error) ->) ->
 		UserController._formatPersonalInfo user, (error, info) ->

+ 0 - 7
services/web/test/UnitTests/coffee/Project/ProjectApiControllerTests.coffee

@@ -40,10 +40,3 @@ describe 'Project api controller', ->
 				resCode.should.equal 500
 				done()
 			@controller.getProjectDetails @req, @res
-
-		it "should destroy the session", (done)->
-			@ProjectDetailsHandler.getDetails.callsArgWith(1, null, @projDetails)
-			@res.json = (data)=>
-				@req.session.destroy.called.should.equal true
-				done()
-			@controller.getProjectDetails @req, @res

+ 0 - 5
services/web/test/UnitTests/coffee/ThirdPartyDataStore/TpdsControllerTests.coffee

@@ -98,8 +98,6 @@ describe 'TpdsController', ->
 		it "should return a success", ->
 			@res.send.calledWith(200).should.equal true
 
-		it "should clear the session", ->
-			@req.session.destroy.called.should.equal true
 			
 	describe 'deleteProjectContents', ->
 		beforeEach ->
@@ -125,6 +123,3 @@ describe 'TpdsController', ->
 		it "should return a success", ->
 			@res.send.calledWith(200).should.equal true
 
-		it "should clear the session", ->
-			@req.session.destroy.called.should.equal true
-