Przeglądaj źródła

sanitise the ref for universities site. and remove unneeded sanitise

Henry Oswald 11 lat temu
rodzic
commit
17fe30ca0f

+ 0 - 1
services/web/app/coffee/Features/Project/ProjectController.coffee

@@ -5,7 +5,6 @@ projectDuplicator = require("./ProjectDuplicator")
 projectCreationHandler = require("./ProjectCreationHandler")
 projectCreationHandler = require("./ProjectCreationHandler")
 editorController = require("../Editor/EditorController")
 editorController = require("../Editor/EditorController")
 metrics = require('../../infrastructure/Metrics')
 metrics = require('../../infrastructure/Metrics')
-sanitize = require('sanitizer')
 Project = require('../../models/Project').Project
 Project = require('../../models/Project').Project
 User = require('../../models/User').User
 User = require('../../models/User').User
 TagsHandler = require("../Tags/TagsHandler")
 TagsHandler = require("../Tags/TagsHandler")

+ 2 - 1
services/web/app/coffee/Features/StaticPages/UniversityController.coffee

@@ -4,6 +4,7 @@ logger = require("logger-sharelatex")
 _ = require("underscore")
 _ = require("underscore")
 ErrorController = require "../Errors/ErrorController"
 ErrorController = require "../Errors/ErrorController"
 StaticPageHelpers = require("./StaticPageHelpers")
 StaticPageHelpers = require("./StaticPageHelpers")
+sanitize = require('sanitizer')
 
 
 module.exports = UniversityController = 
 module.exports = UniversityController = 
 
 
@@ -20,7 +21,7 @@ module.exports = UniversityController =
 			data = data.trim()
 			data = data.trim()
 			try
 			try
 				data = JSON.parse(data)
 				data = JSON.parse(data)
-				data.content = data.content.replace(/__ref__/g, req.query.ref)
+				data.content = data.content.replace(/__ref__/g, sanitize.escape(req.query.ref))
 			catch err
 			catch err
 				logger.err err:err, data:data, "error parsing data from data"
 				logger.err err:err, data:data, "error parsing data from data"
 			res.render "university/university_holder", data
 			res.render "university/university_holder", data