فهرست منبع

Merge pull request #14995 from overleaf/jdt-detach-breaks-on-clone

remove messageComponent until we handle markup

GitOrigin-RevId: d4220277d3cb16eda32325eb3ba2f70102e36d2c
Jimmy Domagala-Tang 3 سال پیش
والد
کامیت
18726f739d
1فایلهای تغییر یافته به همراه4 افزوده شده و 1 حذف شده
  1. 4 1
      services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js

+ 4 - 1
services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js

@@ -48,7 +48,10 @@ export default {
           )
           if (Array.isArray(message)) {
             entry.message = message[0]
-            entry.messageComponent = message[1]
+            // removing the messageComponent, as the markup possible in it was causing crashes when
+            //  attempting to broadcast it in the detach-context (cant structuredClone an html node)
+            // see https://github.com/overleaf/internal/discussions/15031 for context
+            // entry.messageComponent = message[1]
           } else {
             entry.message = message
           }