Ver Fonte

Merge pull request #3684 from overleaf/pr-increase-log-level-payment-form-422s

Increase Recurly 422 log level to error

GitOrigin-RevId: 6ce0bca338d81660b62b74584a851a825114c4f2
Jessica Lawshe há 5 anos atrás
pai
commit
195785194d

+ 1 - 1
services/web/app/src/Features/Subscription/SubscriptionController.js

@@ -225,7 +225,7 @@ module.exports = SubscriptionController = {
             err instanceof SubscriptionErrors.RecurlyTransactionError ||
             err instanceof SubscriptionErrors.RecurlyTransactionError ||
             err instanceof Errors.InvalidError
             err instanceof Errors.InvalidError
           ) {
           ) {
-            logger.warn(err)
+            logger.error({ err }, 'recurly transaction error, potential 422')
             return HttpErrorHandler.unprocessableEntity(
             return HttpErrorHandler.unprocessableEntity(
               req,
               req,
               res,
               res,

+ 2 - 1
services/web/test/unit/src/Subscription/SubscriptionControllerTests.js

@@ -109,7 +109,8 @@ describe('SubscriptionController', function() {
         '../../infrastructure/GeoIpLookup': this.GeoIpLookup,
         '../../infrastructure/GeoIpLookup': this.GeoIpLookup,
         'logger-sharelatex': {
         'logger-sharelatex': {
           log() {},
           log() {},
-          warn() {}
+          warn() {},
+          error() {}
         },
         },
         'settings-sharelatex': this.settings,
         'settings-sharelatex': this.settings,
         '../User/UserGetter': this.UserGetter,
         '../User/UserGetter': this.UserGetter,