Explorar el Código

Merge pull request #6886 from overleaf/jpa-less-verbose-ci

[web] skip HIBP check for all tests but the HIBP specific ones

GitOrigin-RevId: 714e69cc2220e7edcef875d6be487ded571cd977
Jessica Lawshe hace 4 años
padre
commit
1c62f82f9c

+ 1 - 1
services/web/test/acceptance/config/settings.test.defaults.js

@@ -35,7 +35,7 @@ module.exports = {
     },
     },
 
 
     haveIBeenPwned: {
     haveIBeenPwned: {
-      enabled: true,
+      enabled: false,
       url: 'http://localhost:1337',
       url: 'http://localhost:1337',
     },
     },
   },
   },

+ 8 - 0
services/web/test/acceptance/src/HaveIBeenPwnedApiTests.js

@@ -1,3 +1,4 @@
+const Settings = require('@overleaf/settings')
 const { expect } = require('chai')
 const { expect } = require('chai')
 const User = require('./helpers/User').promises
 const User = require('./helpers/User').promises
 const MockHaveIBeenPwnedApiClass = require('./mocks/MockHaveIBeenPwnedApi')
 const MockHaveIBeenPwnedApiClass = require('./mocks/MockHaveIBeenPwnedApi')
@@ -60,6 +61,13 @@ async function resetPassword(password) {
 }
 }
 
 
 describe('HaveIBeenPwnedApi', function () {
 describe('HaveIBeenPwnedApi', function () {
+  before(function () {
+    Settings.apis.haveIBeenPwned.enabled = true
+  })
+  after(function () {
+    Settings.apis.haveIBeenPwned.enabled = false
+  })
+
   describe('login with weak password', function () {
   describe('login with weak password', function () {
     beforeEach(function () {
     beforeEach(function () {
       user = new User()
       user = new User()