Pārlūkot izejas kodu

If analytics is not configured, produce a ServiceNotConfiguredError

Shane Kilkelly 9 gadi atpakaļ
vecāks
revīzija
1ed1eaaa05

+ 8 - 1
services/web/app/coffee/Features/Analytics/AnalyticsController.coffee

@@ -1,7 +1,14 @@
 AnalyticsManager = require "./AnalyticsManager"
+Errors = require "../Errors/Errors"
+
 
 module.exports = AnalyticsController =
 	recordEvent: (req, res, next) ->
 		AnalyticsManager.recordEvent req.session?.user?._id, req.params.event, req.body, (error) ->
-			return next(error) if error?
+			if error?
+				if error instanceof Errors.ServiceNotConfiguredError
+					# ignore, no-op
+					return next(204)
+				else
+					return next(error)
 			res.send 204

+ 2 - 2
services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee

@@ -2,6 +2,7 @@ settings = require "settings-sharelatex"
 logger = require "logger-sharelatex"
 _ = require "underscore"
 request = require "request"
+Errors = require '../Errors/Errors'
 
 
 makeRequest = (opts, callback)->
@@ -10,8 +11,7 @@ makeRequest = (opts, callback)->
 		opts.url = "#{settings.apis.analytics.url}#{urlPath}"
 		request opts, callback
 	else
-		callback()
-
+		callback(new Errors.ServiceNotConfiguredError('Analytics service not configured'))
 
 
 module.exports =