Przeglądaj źródła

Fix invitation resend

Alberto Fernández Capel 8 lat temu
rodzic
commit
1fc047d08e

+ 1 - 1
services/web/app/coffee/Features/Email/EmailBuilder.coffee

@@ -125,7 +125,7 @@ templates.verifyEmailToJoinTeam =
 	type:"notification"
 	type:"notification"
 	plainTextTemplate: _.template """
 	plainTextTemplate: _.template """
 
 
-Please click the button below to join the team and enjoy the benefits of an upgraded  <%= settings.appName %> account.
+Please click the button below to join the team and enjoy the benefits of an upgraded  <%= appName %> account.
 
 
 <%= acceptInviteUrl %>
 <%= acceptInviteUrl %>
 
 

+ 9 - 5
services/web/app/coffee/Features/Subscription/TeamInvitesHandler.coffee

@@ -86,12 +86,15 @@ createInvite = (subscription, email, inviterName, callback) ->
 		invite = subscription.teamInvites.find (invite) -> invite.email == email
 		invite = subscription.teamInvites.find (invite) -> invite.email == email
 
 
 		if !invite?
 		if !invite?
-			invite ||= { email: email }
+			invite = {
+				email: email
+				inviterName: inviterName
+				token: crypto.randomBytes(32).toString("hex")
+				sentAt: new Date()
+			}
 			subscription.teamInvites.push(invite)
 			subscription.teamInvites.push(invite)
-
-		invite.inviterName = inviterName
-		invite.token  = crypto.randomBytes(32).toString("hex")
-		invite.sentAt = new Date()
+		else
+			invite.sentAt = new Date()
 
 
 		subscription.save (error) ->
 		subscription.save (error) ->
 			return callback(error) if error?
 			return callback(error) if error?
@@ -100,6 +103,7 @@ createInvite = (subscription, email, inviterName, callback) ->
 				to: email
 				to: email
 				inviterName: inviterName
 				inviterName: inviterName
 				acceptInviteUrl: "#{settings.siteUrl}/subscription/invites/#{invite.token}/"
 				acceptInviteUrl: "#{settings.siteUrl}/subscription/invites/#{invite.token}/"
+				appName: settings.appName
 			EmailHandler.sendEmail "verifyEmailToJoinTeam", opts, (error) ->
 			EmailHandler.sendEmail "verifyEmailToJoinTeam", opts, (error) ->
 				return callback(error, invite)
 				return callback(error, invite)
 
 

+ 0 - 1
services/web/test/unit/coffee/Subscription/TeamInvitesHandlerTests.coffee

@@ -127,7 +127,6 @@ describe "TeamInvitesHandler", ->
 				expect(@subscription.teamInvites).to.deep.include invite
 				expect(@subscription.teamInvites).to.deep.include invite
 
 
 				expect(invite.email).to.eq originalInvite.email
 				expect(invite.email).to.eq originalInvite.email
-				expect(invite.token).not.to.eq originalInvite.token
 
 
 				@subscription.save.calledOnce.should.eq true
 				@subscription.save.calledOnce.should.eq true