Kaynağa Gözat

Merge pull request #1940 from overleaf/sk-catch-gitbridge-content-errors

GitBridge: catch 404 errors when fetching content from git-bridge api
GitOrigin-RevId: 411759ebae1fb81ebfa942e117d1ef3c47215d0e
Shane Kilkelly 7 yıl önce
ebeveyn
işleme
26af3e091f

+ 9 - 2
services/web/app/src/infrastructure/FileWriter.js

@@ -105,12 +105,19 @@ module.exports = FileWriter = {
     }
     }
     callback = _.once(callback)
     callback = _.once(callback)
     const stream = request.get(url)
     const stream = request.get(url)
-    return stream.on('response', function(response) {
+    stream.on('error', function(err) {
+      logger.warn(
+        { err, identifier, url },
+        '[writeUrlToDisk] something went wrong with writing to disk'
+      )
+      callback(err)
+    })
+    stream.on('response', function(response) {
       if (response.statusCode >= 200 && response.statusCode < 300) {
       if (response.statusCode >= 200 && response.statusCode < 300) {
         return FileWriter.writeStreamToDisk(identifier, stream, callback)
         return FileWriter.writeStreamToDisk(identifier, stream, callback)
       } else {
       } else {
         const err = new Error(`bad response from url: ${response.statusCode}`)
         const err = new Error(`bad response from url: ${response.statusCode}`)
-        logger.warn({ err, identifier, url }, err.message)
+        logger.warn({ err, identifier, url }, `[writeUrlToDisk] ${err.message}`)
         return callback(err)
         return callback(err)
       }
       }
     })
     })