Просмотр исходного кода

Merge pull request #4 from overleaf/ae-deprecate-coffee

Add deprecation warning for .coffee settings files
Alf Eaton 5 лет назад
Родитель
Сommit
27778ed30c
1 измененных файлов с 10 добавлено и 2 удалено
  1. 10 2
      libraries/settings/Settings.coffee

+ 10 - 2
libraries/settings/Settings.coffee

@@ -12,8 +12,14 @@ merge = (settings, defaults) ->
 
 defaultSettingsPath = path.normalize(__dirname + "/../../config/settings.defaults")
 
-if fs.existsSync("#{defaultSettingsPath}.coffee") or fs.existsSync("#{defaultSettingsPath}.js")
-	defaults = require(defaultSettingsPath)
+if fs.existsSync("#{defaultSettingsPath}.js")
+	console.log "Using default settings from #{defaultSettingsPath}.js"
+	defaults = require("#{defaultSettingsPath}.js")
+	settingsExist = true
+else if fs.existsSync("#{defaultSettingsPath}.coffee")
+	console.warn "CoffeeScript settings file #{defaultSettingsPath}.coffee is deprecated, please convert to JavaScript"
+	console.log "Using default settings from #{defaultSettingsPath}.coffee"
+	defaults = require("#{defaultSettingsPath}.coffee")
 	settingsExist = true
 else
 	defaults = {}
@@ -31,6 +37,8 @@ else
 
 for file in possibleConfigFiles
 	if fs.existsSync(file)
+		if file.endsWith('.coffee')
+			console.warn "CoffeeScript settings file #{file} is deprecated, please convert to JavaScript"
 		console.log "Using settings from " + file
 		module.exports = merge(require(file), defaults)
 		settingsExist = true