Przeglądaj źródła

added client side checks on how long project or entity names can be

150 chars should be safely under the 1024 bytes mongo index limit
Henry Oswald 12 lat temu
rodzic
commit
28b1e6bfe5

+ 3 - 2
services/web/public/coffee/ide/file-tree/FileTreeManager.coffee

@@ -272,9 +272,10 @@ define [
 
 
 		renameEntity: (entity, name, callback = (error) ->) ->
 		renameEntity: (entity, name, callback = (error) ->) ->
 			return if entity.name == name
 			return if entity.name == name
-			entity.name = name
+			if name.length < 150
+				entity.name = name
 			return @ide.$http.post "/project/#{@ide.project_id}/#{entity.type}/#{entity.id}/rename", {
 			return @ide.$http.post "/project/#{@ide.project_id}/#{entity.type}/#{entity.id}/rename", {
-				name: name,
+				name: entity.name,
 				_csrf: window.csrfToken
 				_csrf: window.csrfToken
 			}
 			}
 
 

+ 4 - 2
services/web/public/coffee/ide/settings/controllers/ProjectNameController.coffee

@@ -12,8 +12,10 @@ define [
 			$scope.$emit "project:rename:start"
 			$scope.$emit "project:rename:start"
 
 
 		$scope.finishRenaming = () ->
 		$scope.finishRenaming = () ->
-			$scope.project.name = $scope.inputs.name
-			settings.saveProjectSettings({name: $scope.inputs.name})
+			newName = $scope.inputs.name
+			if newName.length < 150
+				$scope.project.name = newName
+			settings.saveProjectSettings({name: $scope.project.name})
 			$scope.state.renaming = false
 			$scope.state.renaming = false
 
 
 		ide.socket.on "projectNameUpdated", (name) ->
 		ide.socket.on "projectNameUpdated", (name) ->

+ 3 - 2
services/web/public/coffee/main/project-list/project-list.coffee

@@ -257,9 +257,10 @@ define [
 				window.location = "/project/#{project_id}"
 				window.location = "/project/#{project_id}"
 
 
 		$scope.renameProject = (project, newName) ->
 		$scope.renameProject = (project, newName) ->
-			project.name = newName
+			if newName.length < 150
+				project.name = newName
 			queuedHttp.post "/project/#{project.id}/rename", {
 			queuedHttp.post "/project/#{project.id}/rename", {
-				newProjectName: newName
+				newProjectName: project.name
 				_csrf: window.csrfToken
 				_csrf: window.csrfToken
 			}
 			}