Merge pull request #2940 from overleaf/as-cleanup-no-undef-disables

Clean up disabling of no-undef eslint rule in frontend

GitOrigin-RevId: 3fb19256b7dd9d41626355960dd9fbcc541e663f

services/web/.eslintrc

@@ -81,7 +81,6 @@
       "files": ["**/test/frontend/**/*.js"],
       "globals": {
         "expect": true,
-        "define": true,
         "$": true
       }
     },
@@ -97,10 +96,8 @@
       // Frontend specific rules
       "files": ["**/frontend/js/**/*.js"],
       "globals": {
-        "define": true,
         "$": true,
         "angular": true,
-        "_": true,
         "ace": true,
         "ga": true,
         "Raven": true, // Backwards compat for Sentry reporting

services/web/modules/launchpad/frontend/js/main/controllers/LaunchpadController.js

@@ -1,7 +1,8 @@
+/* global io */
+
 /* eslint-disable
     max-len,
     no-return-assign,
-    no-undef,
 */
 // TODO: This file was created by bulk-decaffeinate.
 // Fix any style issues and re-enable lint.