Explorar el Código

Update RangesTracker

James Allen hace 9 años
padre
commit
31ae2e7124

+ 7 - 6
services/web/public/coffee/ide/review-panel/RangesTracker.coffee

@@ -410,14 +410,10 @@ load = (EventEmitter) ->
 				@emit "changes:moved", moved_changes
 				@emit "changes:moved", moved_changes
 
 
 		_addOp: (op, metadata) ->
 		_addOp: (op, metadata) ->
-			# Don't take a reference to the existing op since we'll modify this in place with future changes
-			clone_op = {}
-			for k,v of op
-				clone_op[k] = v
 			change = {
 			change = {
 				id: @newId()
 				id: @newId()
-				op: clone_op
-				metadata: metadata
+				op: @_clone(op) # Don't take a reference to the existing op since we'll modify this in place with future changes
+				metadata: @_clone(metadata)
 			}
 			}
 			@changes.push change
 			@changes.push change
 
 
@@ -489,6 +485,11 @@ load = (EventEmitter) ->
 				else # Only update to the current change if we haven't removed it.
 				else # Only update to the current change if we haven't removed it.
 					previous_change = change
 					previous_change = change
 			return { moved_changes, remove_changes }
 			return { moved_changes, remove_changes }
+		
+		_clone: (object) ->
+			clone = {}
+			(clone[k] = v for k,v of object)
+			return clone
 
 
 if define?
 if define?
 	define ["utils/EventEmitter"], load
 	define ["utils/EventEmitter"], load