Explorar o código

Merge pull request #6695 from overleaf/ae-cm6-review-panel-timing

[web] [cm6] Improve track changes extension timings

GitOrigin-RevId: 6e374b785daf14bd4d4576747faa0a9b20c4d346
Alf Eaton %!s(int64=4) %!d(string=hai) anos
pai
achega
34a296747b

+ 6 - 6
services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js

@@ -520,21 +520,21 @@ export default App.controller(
       }
       }
 
 
       if (changed) {
       if (changed) {
-        return $scope.$broadcast('entries:changed')
+        // TODO: unused?
+        $scope.$broadcast('entries:changed')
       }
       }
+
+      return entries
     }
     }
 
 
     $scope.$on('editor:track-changes:changed', function () {
     $scope.$on('editor:track-changes:changed', function () {
       const doc_id = $scope.editor.open_doc_id
       const doc_id = $scope.editor.open_doc_id
-      updateEntries(doc_id)
+      const entries = updateEntries(doc_id)
 
 
       // For now, not worrying about entry panels for rich text
       // For now, not worrying about entry panels for rich text
       if (!$scope.editor.showRichText) {
       if (!$scope.editor.showRichText) {
         $scope.$broadcast('review-panel:recalculate-screen-positions')
         $scope.$broadcast('review-panel:recalculate-screen-positions')
-        dispatchReviewPanelEvent(
-          'recalculate-screen-positions',
-          getDocEntries($scope.editor.open_doc_id)
-        )
+        dispatchReviewPanelEvent('recalculate-screen-positions', entries)
 
 
         return $scope.$broadcast('review-panel:layout')
         return $scope.$broadcast('review-panel:layout')
       }
       }