Преглед на файлове

prevent calls to UserGetter.getUser with null query

Tim Alby преди 8 години
родител
ревизия
41b92d4647
променени са 2 файла, в които са добавени 6 реда и са изтрити 0 реда
  1. 1 0
      services/web/app/coffee/Features/User/UserGetter.coffee
  2. 5 0
      services/web/test/unit/coffee/User/UserGetterTests.coffee

+ 1 - 0
services/web/app/coffee/Features/User/UserGetter.coffee

@@ -8,6 +8,7 @@ Errors = require("../Errors/Errors")
 
 module.exports = UserGetter =
 	getUser: (query, projection, callback = (error, user) ->) ->
+		return callback(new Error("no query provided")) unless query?
 		if query?.email?
 			return callback(new Error("Don't use getUser to find user by email"), null)
 		if arguments.length == 2

+ 5 - 0
services/web/test/unit/coffee/User/UserGetterTests.coffee

@@ -48,6 +48,11 @@ describe "UserGetter", ->
 				error.should.exist
 				done()
 
+		it "should not allow null query", (done)->
+			@UserGetter.getUser null, {}, (error, user) =>
+				error.should.exist
+				done()
+
 	describe "getUserFullEmails", ->
 		it "should get user", (done)->
 			@UserGetter.getUser = sinon.stub().callsArgWith(2, null, @fakeUser)