Просмотр исходного кода

Merge pull request #2354 from overleaf/em-disallow-console

Disallow console.log in backend code

GitOrigin-RevId: 53ff1f2f2585d05a0f2380336227c50524aee08c
Jessica Lawshe 7 лет назад
Родитель
Сommit
41d77889da
2 измененных файлов с 1 добавлено и 2 удалено
  1. 1 1
      services/web/.eslintrc
  2. 0 1
      services/web/app/src/Features/Analytics/AnalyticsManager.js

+ 1 - 1
services/web/.eslintrc

@@ -87,7 +87,7 @@
     },
     },
     {
     {
       // Backend specific rules
       // Backend specific rules
-      "files": ["**/app/*/src/**/*.js"],
+      "files": ["**/app/src/**/*.js"],
       "rules": {
       "rules": {
         // don't allow console.log in backend code
         // don't allow console.log in backend code
         "no-console": "error"
         "no-console": "error"

+ 0 - 1
services/web/app/src/Features/Analytics/AnalyticsManager.js

@@ -152,7 +152,6 @@ module.exports = {
     }
     }
     makeAnalyticsRequest(userId, opts, function(err, response, body) {
     makeAnalyticsRequest(userId, opts, function(err, response, body) {
       if (err != null) {
       if (err != null) {
-        console.log(response, opts)
         logger.warn({ userId, err }, 'error getting last occurance of event')
         logger.warn({ userId, err }, 'error getting last occurance of event')
         callback(err)
         callback(err)
       } else {
       } else {