Procházet zdrojové kódy

Merge pull request #11996 from overleaf/jel-pdf-detach-download

[web] Add download attribute to download button in file view

GitOrigin-RevId: 7fdbd970d87bd3678863f23be993a34140a5726b
Jessica Lawshe před 3 roky
rodič
revize
4380f20f08

+ 3 - 1
services/web/frontend/js/features/file-tree/components/file-tree-item/file-tree-item-menu-items.js

@@ -24,7 +24,9 @@ function FileTreeItemMenuItems() {
         <MenuItem onClick={startRenaming}>{t('rename')}</MenuItem>
         <MenuItem onClick={startRenaming}>{t('rename')}</MenuItem>
       ) : null}
       ) : null}
       {downloadPath ? (
       {downloadPath ? (
-        <MenuItem href={downloadPath}>{t('download')}</MenuItem>
+        <MenuItem href={downloadPath} download>
+          {t('download')}
+        </MenuItem>
       ) : null}
       ) : null}
       {canDelete ? (
       {canDelete ? (
         <MenuItem onClick={startDeleting}>{t('delete')}</MenuItem>
         <MenuItem onClick={startDeleting}>{t('delete')}</MenuItem>

+ 1 - 0
services/web/frontend/js/features/file-view/components/file-view-header.js

@@ -127,6 +127,7 @@ export default function FileViewHeader({ file, storeReferencesKeys }) {
       )}
       )}
       &nbsp;
       &nbsp;
       <a
       <a
+        download
         href={`/project/${projectId}/file/${file.id}`}
         href={`/project/${projectId}/file/${file.id}`}
         className="btn btn-secondary-info btn-secondary"
         className="btn btn-secondary-info btn-secondary"
       >
       >