Просмотр исходного кода

Merge pull request #15793 from overleaf/jpa-compile-domain-cleanup

[web] tear down split test for new compile domain

GitOrigin-RevId: 7ab417d67e508cd95bd4e78ce7ce2a993c789dca
Jakob Ackermann 2 лет назад
Родитель
Сommit
453edbfe0a

+ 1 - 10
services/web/app/src/Features/Compile/CompileController.js

@@ -57,16 +57,7 @@ const getSplitTestOptions = callbackify(async function (req, res) {
   } catch (e) {}
   const editorReq = { ...req, query }
 
-  const { variant: domainVariant } =
-    await SplitTestHandler.promises.getAssignment(
-      editorReq,
-      res,
-      'pdf-download-domain'
-    )
-  const pdfDownloadDomain =
-    domainVariant === 'user' && Settings.compilesUserContentDomain
-      ? Settings.compilesUserContentDomain
-      : Settings.pdfDownloadDomain
+  const pdfDownloadDomain = Settings.pdfDownloadDomain
 
   if (!req.query.enable_pdf_caching) {
     // The frontend does not want to do pdf caching.

+ 0 - 1
services/web/app/views/project/editor/meta.pug

@@ -13,7 +13,6 @@ meta(name="ol-wikiEnabled" data-type="boolean" content=settings.proxyLearn)
 meta(name="ol-gitBridgePublicBaseUrl" content=gitBridgePublicBaseUrl)
 meta(name="ol-gitBridgeEnabled" data-type="boolean" content=gitBridgeEnabled)
 meta(name="ol-compilesUserContentDomain" content=settings.compilesUserContentDomain)
-meta(name="ol-fallbackCompileDomain" content=settings.pdfDownloadDomain)
 //- Set base path for Ace scripts loaded on demand/workers and don't use cdn
 meta(name="ol-aceBasePath" content="/js/" + lib('ace'))
 //- enable doc hash checking for all projects

+ 1 - 2
services/web/config/settings.defaults.js

@@ -586,8 +586,7 @@ module.exports = {
   // disablePerUserCompiles: true
 
   // Domain the client (pdfjs) should download the compiled pdf from
-  pdfDownloadDomain: process.env.PDF_DOWNLOAD_DOMAIN, // "http://clsi-lb:3014"
-  compilesUserContentDomain: process.env.COMPILES_USER_CONTENT_DOMAIN,
+  pdfDownloadDomain: process.env.COMPILES_USER_CONTENT_DOMAIN, // "http://clsi-lb:3014"
 
   // By default turn on feature flag, can be overridden per request.
   enablePdfCaching: process.env.ENABLE_PDF_CACHING === 'true',