Преглед на файлове

Merge pull request #8703 from overleaf/ae-threads-loaded

Ensure that the loaded_threads event isn't dispatched for read-only link sharing users

GitOrigin-RevId: e03581f29f1a0aff122c3c16f4f6a3b70293c301
Alf Eaton преди 4 години
родител
ревизия
4657465c0d
променени са 1 файла, в които са добавени 8 реда и са изтрити 9 реда
  1. 8 9
      services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js

+ 8 - 9
services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js

@@ -488,15 +488,14 @@ export default App.controller(
         }
       }
 
-      if (
-        rangesTracker.comments.length > 0 &&
-        !window.isRestrictedTokenMember
-      ) {
-        ensureThreadsAreLoaded()
-      } else {
-        // ensure that tracked changes are highlighted even if no comments are loaded
-        ide.$scope.loadingThreads = false
-        dispatchReviewPanelEvent('loaded_threads')
+      if (!window.isRestrictedTokenMember) {
+        if (rangesTracker.comments.length > 0) {
+          ensureThreadsAreLoaded()
+        } else {
+          // ensure that tracked changes are highlighted even if no comments are loaded
+          ide.$scope.loadingThreads = false
+          dispatchReviewPanelEvent('loaded_threads')
+        }
       }
 
       for (const comment of Array.from(rangesTracker.comments)) {