Sfoglia il codice sorgente

Merge pull request #13118 from overleaf/mj-fix-centering-editable-graphics

[web] Always update centering in editablegraphics updateDOM

GitOrigin-RevId: 366a109c2006dea3cd3660f7a380fbbc0e203cca
Mathias Jakobsen 3 anni fa
parent
commit
47b1a731fb

+ 7 - 5
services/web/frontend/js/features/source-editor/extensions/visual/visual-widgets/editable-graphics.ts

@@ -19,19 +19,21 @@ export class EditableGraphicsWidget extends GraphicsWidget {
   }
 
   updateDOM(element: HTMLImageElement, view: EditorView): boolean {
+    this.destroyed = false
+    element.classList.toggle('ol-cm-environment-centered', this.centered)
     if (
       this.filePath === element.dataset.filepath &&
       element.dataset.width === String(this.figureData?.width?.toString())
     ) {
       // Figure remained the same, so just update the event listener on the button
-      this.setEditDispatcher(
-        element.querySelector('.ol-cm-graphics-edit-button')!,
-        view
+      const button = element.querySelector<HTMLButtonElement>(
+        '.ol-cm-graphics-edit-button'
       )
+      if (button) {
+        this.setEditDispatcher(button, view)
+      }
       return true
     }
-    this.destroyed = false
-    element.classList.toggle('ol-cm-environment-centered', this.centered)
     this.renderGraphic(element, view)
     return true
   }