Merge pull request #1844 from overleaf/em-no-pdf-eps-previews

 Do not try to preview PDF or EPS files

GitOrigin-RevId: fd4fcd1c57573e9bc5fa1eed74e3430188482be4

services/web/public/src/ide/binary-files/controllers/BinaryFileController.js

@@ -1,19 +1,3 @@
-/* eslint-disable
-    camelcase,
-    max-len,
-    no-return-assign,
-    no-undef,
-    no-unused-vars,
-*/
-// TODO: This file was created by bulk-decaffeinate.
-// Fix any style issues and re-enable lint.
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * DS103: Rewrite code to no longer use __guard__
- * DS207: Consider shorter variations of null checks
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
- */
 define(['base', 'moment'], (App, moment) =>
   App.controller('BinaryFileController', [
     '$scope',
@@ -24,25 +8,22 @@ define(['base', 'moment'], (App, moment) =>
     'ide',
     'waitFor',
     function($scope, $rootScope, $http, $timeout, $element, ide, waitFor) {
-      let loadTextFileFilePreview, setHeight
-      const TWO_MEGABYTES = 2 * 1024 * 1024
-
       const textExtensions = ['bib', 'tex', 'txt', 'cls', 'sty']
-      const imageExtentions = ['png', 'jpg', 'jpeg', 'gif']
-      const previewableExtensions = ['eps', 'pdf']
+      const imageExtensions = ['png', 'jpg', 'jpeg', 'gif']
+      const previewableExtensions = []
 
       const extension = file =>
-        __guard__(file.name.split('.').pop(), x => x.toLowerCase())
+        file.name
+          .split('.')
+          .pop()
+          .toLowerCase()
 
-      $scope.isTextFile = () => {
-        return textExtensions.indexOf(extension($scope.openFile)) > -1
-      }
-      $scope.isImageFile = () => {
-        return imageExtentions.indexOf(extension($scope.openFile)) > -1
-      }
-      $scope.isPreviewableFile = () => {
-        return previewableExtensions.indexOf(extension($scope.openFile)) > -1
-      }
+      $scope.isTextFile = () =>
+        textExtensions.indexOf(extension($scope.openFile)) > -1
+      $scope.isImageFile = () =>
+        imageExtensions.indexOf(extension($scope.openFile)) > -1
+      $scope.isPreviewableFile = () =>
+        previewableExtensions.indexOf(extension($scope.openFile)) > -1
       $scope.isUnpreviewableFile = () =>
         !$scope.isTextFile() &&
         !$scope.isImageFile() &&
@@ -79,15 +60,15 @@ define(['base', 'moment'], (App, moment) =>
       $scope.refreshFile = function(file) {
         $scope.refreshing = true
         $scope.refreshError = null
-        return ide.fileTreeManager
+        ide.fileTreeManager
           .refreshLinkedFile(file)
           .then(function(response) {
             const { data } = response
-            const { new_file_id } = data
+            const { newFileId } = data
             $timeout(
               () =>
                 waitFor(
-                  () => ide.fileTreeManager.findEntityById(new_file_id),
+                  () => ide.fileTreeManager.findEntityById(newFileId),
                   5000
                 )
                   .then(newFile => ide.binaryFilesManager.openFile(newFile))
@@ -95,7 +76,7 @@ define(['base', 'moment'], (App, moment) =>
 
               0
             )
-            return ($scope.refreshError = null)
+            $scope.refreshError = null
           })
           .catch(response => ($scope.refreshError = response.data))
           .finally(() => {
@@ -116,7 +97,7 @@ define(['base', 'moment'], (App, moment) =>
       $scope.failedLoad = false
       window.sl_binaryFilePreviewError = () => {
         $scope.failedLoad = true
-        return $scope.$apply()
+        $scope.$apply()
       }
 
       // Callback fired when the `img` tag is done loading,
@@ -124,69 +105,7 @@ define(['base', 'moment'], (App, moment) =>
       $scope.imgLoaded = false
       window.sl_binaryFilePreviewLoaded = () => {
         $scope.imgLoaded = true
-        return $scope.$apply()
-      }
-      ;(loadTextFileFilePreview = function() {
-        if (!$scope.isTextFile()) {
-          return
-        }
-        const url = `/project/${project_id}/file/${
-          $scope.openFile.id
-        }?range=0-${TWO_MEGABYTES}`
-        $scope.textPreview.data = null
-        $scope.textPreview.loading = true
-        $scope.textPreview.shouldShowDots = false
         $scope.$apply()
-        return $http({
-          url,
-          method: 'GET',
-          transformResponse: null // Don't parse JSON
-        })
-          .then(function(response) {
-            let { data } = response
-            $scope.textPreview.error = false
-            // show dots when payload is closs to cutoff
-            if (data.length >= TWO_MEGABYTES - 200) {
-              $scope.textPreview.shouldShowDots = true
-              // remove last partial line
-              data = __guardMethod__(data, 'replace', o =>
-                o.replace(/\n.*$/, '')
-              )
-            }
-            $scope.textPreview.data = data
-            return $timeout(setHeight, 0)
-          })
-          .catch(function(error) {
-            console.error(error)
-            $scope.textPreview.error = true
-            return ($scope.textPreview.loading = false)
-          })
-      })()
-
-      return (setHeight = function() {
-        const $preview = $element.find('.text-preview .scroll-container')
-        const $footer = $element.find('.binary-file-footer')
-        const maxHeight = $element.height() - $footer.height() - 14 // borders + margin
-        $preview.css({ 'max-height': maxHeight })
-        // Don't show the preview until we've set the height, otherwise we jump around
-        return ($scope.textPreview.loading = false)
-      })
+      }
     }
   ]))
-
-function __guard__(value, transform) {
-  return typeof value !== 'undefined' && value !== null
-    ? transform(value)
-    : undefined
-}
-function __guardMethod__(obj, methodName, transform) {
-  if (
-    typeof obj !== 'undefined' &&
-    obj !== null &&
-    typeof obj[methodName] === 'function'
-  ) {
-    return transform(obj, methodName)
-  } else {
-    return undefined
-  }
-}