Explorar el Código

Send user data in /threads dat

James Allen hace 9 años
padre
commit
4e128b6ab7

+ 1 - 1
services/web/app/coffee/Features/Chat/ChatController.coffee

@@ -28,7 +28,7 @@ module.exports =
 		logger.log project_id:project_id, query:query, "getting messages"
 		logger.log project_id:project_id, query:query, "getting messages"
 		ChatApiHandler.getGlobalMessages project_id, query.limit, query.before, (err, messages) ->
 		ChatApiHandler.getGlobalMessages project_id, query.limit, query.before, (err, messages) ->
 			return next(err) if err?
 			return next(err) if err?
-			CommentsController._injectUserInfoIntoThreads [{ messages: messages }], (err) ->
+			CommentsController._injectUserInfoIntoThreads {global: { messages: messages }}, (err) ->
 				return next(err) if err?
 				return next(err) if err?
 				logger.log length: messages?.length, "sending messages to client"
 				logger.log length: messages?.length, "sending messages to client"
 				res.json messages
 				res.json messages

+ 1 - 1
services/web/app/coffee/Features/Comments/CommentsController.coffee

@@ -62,7 +62,7 @@ module.exports = CommentsController =
 				callback null, user
 				callback null, user
 		
 		
 		jobs = []
 		jobs = []
-		for thread in threads
+		for thread_id, thread of threads
 			do (thread) ->
 			do (thread) ->
 				if thread.resolved
 				if thread.resolved
 					jobs.push (cb) ->
 					jobs.push (cb) ->

+ 8 - 8
services/web/test/UnitTests/coffee/Comments/CommentsControllerTests.coffee

@@ -151,8 +151,8 @@ describe "CommentsController", ->
 				return { "formatted": user["mock"] }
 				return { "formatted": user["mock"] }
 			
 			
 		it "should inject a user object into messaged and resolved data", (done) ->
 		it "should inject a user object into messaged and resolved data", (done) ->
-			@CommentsController._injectUserInfoIntoThreads [
-				{
+			@CommentsController._injectUserInfoIntoThreads {
+				thread1: {
 					resolved: true
 					resolved: true
 					resolved_by_user_id: "user_id_1"
 					resolved_by_user_id: "user_id_1"
 					messages: [{
 					messages: [{
@@ -163,15 +163,15 @@ describe "CommentsController", ->
 						content: "bar"
 						content: "bar"
 					}]
 					}]
 				},
 				},
-				{
+				thread2: {
 					messages: [{
 					messages: [{
 						user_id: "user_id_1"
 						user_id: "user_id_1"
 						content: "baz"
 						content: "baz"
 					}]
 					}]
 				}
 				}
-			], (error, threads) ->
-				expect(threads).to.deep.equal [
-					{
+			}, (error, threads) ->
+				expect(threads).to.deep.equal {
+					thread1: {
 						resolved: true
 						resolved: true
 						resolved_by_user_id: "user_id_1"
 						resolved_by_user_id: "user_id_1"
 						resolved_by_user: { "formatted": "user_1" }
 						resolved_by_user: { "formatted": "user_1" }
@@ -185,14 +185,14 @@ describe "CommentsController", ->
 							content: "bar"
 							content: "bar"
 						}]
 						}]
 					},
 					},
-					{
+					thread2: {
 						messages: [{
 						messages: [{
 							user_id: "user_id_1"
 							user_id: "user_id_1"
 							user: { "formatted": "user_1" }
 							user: { "formatted": "user_1" }
 							content: "baz"
 							content: "baz"
 						}]
 						}]
 					}
 					}
-				]
+				}
 				done()
 				done()
 
 
 		it "should only need to look up each user once", (done) ->
 		it "should only need to look up each user once", (done) ->