Просмотр исходного кода

Merge pull request #3879 from overleaf/jel-ja-wiki-mathjax

Fix learn wiki XSS

GitOrigin-RevId: 3964b2eaf56ef57ec34e4cdd3e683dd36f9eae6e
Jessica Lawshe 5 лет назад
Родитель
Сommit
5220198991
1 измененных файлов с 0 добавлено и 9 удалено
  1. 0 9
      services/web/frontend/js/directives/mathjax.js

+ 0 - 9
services/web/frontend/js/directives/mathjax.js

@@ -8,15 +8,6 @@ export default App.directive('mathjax', function($compile, $parse) {
     link(scope, element, attrs) {
     link(scope, element, attrs) {
       if (!(MathJax && MathJax.Hub)) return
       if (!(MathJax && MathJax.Hub)) return
 
 
-      // Allowing HTML can be unsafe unless using something like
-      // `ng-bind-html` because of potential Angular XSS via {{/}}
-      if (!$parse(attrs.mathjaxAllowHtml)(scope)) {
-        const mathJaxContents = element.html()
-        const nonBindableEl = $compile('<span ng-non-bindable></span>')({})
-        element.html('').append(nonBindableEl)
-        nonBindableEl.html(mathJaxContents)
-      }
-
       if (attrs.delimiter !== 'no-single-dollar') {
       if (attrs.delimiter !== 'no-single-dollar') {
         const inlineMathConfig =
         const inlineMathConfig =
           MathJax.Hub.config && MathJax.Hub.config.tex2jax.inlineMath
           MathJax.Hub.config && MathJax.Hub.config.tex2jax.inlineMath