Просмотр исходного кода

Merge pull request #188 from overleaf/jpa-drop-duplicate-log

[misc] drop duplicate logs
Jakob Ackermann 6 лет назад
Родитель
Сommit
54c0853aa5

+ 0 - 1
services/real-time/app/js/WebApiManager.js

@@ -49,7 +49,6 @@ module.exports = {
             data.isRestrictedUser
             data.isRestrictedUser
           )
           )
         } else if (response.statusCode === 429) {
         } else if (response.statusCode === 429) {
-          logger.log(project_id, user_id, 'rate-limit hit when joining project')
           callback(
           callback(
             new CodedError(
             new CodedError(
               'rate-limit hit when joining project',
               'rate-limit hit when joining project',

+ 0 - 4
services/real-time/app/js/WebsocketController.js

@@ -462,10 +462,6 @@ module.exports = WebsocketController = {
       update,
       update,
       function (error) {
       function (error) {
         if (error) {
         if (error) {
-          logger.warn(
-            { err: error, doc_id, client_id: client.id, version: update.v },
-            'client is not authorized to make update'
-          )
           setTimeout(
           setTimeout(
             () =>
             () =>
               // Disconnect, but give the client the chance to receive the error
               // Disconnect, but give the client the chance to receive the error

+ 2 - 2
services/real-time/test/unit/js/WebsocketControllerTests.js

@@ -1493,8 +1493,8 @@ describe('WebsocketController', function () {
       // it "should disconnect the client", ->
       // it "should disconnect the client", ->
       // 	@client.disconnect.called.should.equal true
       // 	@client.disconnect.called.should.equal true
 
 
-      it('should log a warning', function () {
-        return this.logger.warn.called.should.equal(true)
+      it('should not log a warning', function () {
+        return this.logger.warn.called.should.equal(false)
       })
       })
 
 
       return it('should call the callback with the error', function () {
       return it('should call the callback with the error', function () {