瀏覽代碼

Order entries in the overview panel based on their place in the document

James Allen 10 年之前
父節點
當前提交
5814d93f5e

+ 6 - 6
services/web/app/views/project/editor/review-panel.jade

@@ -47,14 +47,14 @@
 			.rp-overview-file-header
 				| {{ getFileName(doc_id) }}
 			.rp-entry-wrapper(
-				ng-repeat="(entry_id, entry) in entries"
+				ng-repeat="(entry_id, entry) in entries | orderOverviewEntries"
 			)
 				div(ng-if="entry.type === 'insert' || entry.type === 'delete'")
 					change-entry(
 						entry="entry"
 						user="users[entry.metadata.user_id]"
-						on-reject="rejectChange(entry_id);"
-						on-accept="acceptChange(entry_id);"
+						on-reject="rejectChange(entry.id);"
+						on-accept="acceptChange(entry.id);"
 						on-indicator-click="toggleReviewPanel();"
 						ng-click="gotoEntry(doc_id, entry)"
 					)
@@ -63,9 +63,9 @@
 					comment-entry(
 						entry="entry"
 						users="users"
-						on-resolve="resolveComment(entry, entry_id)"
-						on-unresolve="unresolveComment(entry_id)"
-						on-delete="deleteComment(entry_id)"
+						on-resolve="resolveComment(entry, entry.id)"
+						on-unresolve="unresolveComment(entry.id)"
+						on-delete="deleteComment(entry.id)"
 						on-reply="submitReply(entry, entry_id);"
 						on-indicator-click="toggleReviewPanel();"
 						ng-click="gotoEntry(doc_id, entry)"

+ 1 - 0
services/web/public/coffee/ide/review-panel/ReviewPanelManager.coffee

@@ -4,4 +4,5 @@ define [
 	"ide/review-panel/directives/changeEntry"
 	"ide/review-panel/directives/commentEntry"
 	"ide/review-panel/directives/addCommentEntry"
+	"ide/review-panel/filters/orderOverviewEntries"
 ], () ->

+ 11 - 0
services/web/public/coffee/ide/review-panel/filters/orderOverviewEntries.coffee

@@ -0,0 +1,11 @@
+define [
+	"base"
+], (App) ->
+	App.filter "orderOverviewEntries", () ->
+		(items) ->
+			array = []
+			for key, value of items
+				value.entry_id = key
+				array.push value
+			array.sort (a, b) -> a.offset - b.offset
+			return array