Parcourir la source

Add missing require stubs and remove console.logs in unit tests

James Allen il y a 9 ans
Parent
commit
59085c1ddd

+ 0 - 1
services/web/app/coffee/Features/Project/ProjectUpdateHandler.coffee

@@ -1,6 +1,5 @@
 Project = require('../../models/Project').Project
 logger = require('logger-sharelatex')
-Project = require("../../models/Project").Project
 
 module.exports = 
 	markAsUpdated : (project_id, callback)->

+ 0 - 1
services/web/test/UnitTests/coffee/Project/ProjectLocatorTests.coffee

@@ -70,7 +70,6 @@ describe 'ProjectLocator', ->
 
 		it 'should give error if element could not be found', (done)->
 			@locator.findElement {project_id:project._id, element_id:"ddsd432nj42", type:"docs"}, (err, foundElement, path, parentFolder)->
-				console.log err
 				err.should.deep.equal new Errors.NotFoundError("entity not found")
 				done()
 

+ 1 - 0
services/web/test/UnitTests/coffee/Project/ProjectUpdateHandlerTests.coffee

@@ -11,6 +11,7 @@ describe 'ProjectUpdateHandler', ->
 		@ProjectModel.update = sinon.stub().callsArg(3)
 		@handler = SandboxedModule.require modulePath, requires:
 			'../../models/Project':{Project:@ProjectModel}
+			'logger-sharelatex' : { log: sinon.stub() }
 
 	describe 'marking a project as recently updated', ->
 		it 'should send an update to mongo', (done)->

+ 1 - 0
services/web/test/UnitTests/coffee/User/UserLocatorTests.coffee

@@ -11,6 +11,7 @@ describe "UserLocator", ->
 		@UserLocator = SandboxedModule.require modulePath, requires:
 			"../../infrastructure/mongojs": db: @db =  { users: {} }
 			"metrics-sharelatex": timeAsyncMethod: sinon.stub()
+			'logger-sharelatex' : { log: sinon.stub() }
 		@db.users =
 			findOne : sinon.stub().callsArgWith(1, null, @user)
 

+ 0 - 1
services/web/test/UnitTests/coffee/User/UserRegistrationHandlerTests.coffee

@@ -96,7 +96,6 @@ describe "UserRegistrationHandler", ->
 			it "should return email registered in the error if there is a non holdingAccount there", (done)->
 				@User.findOne.callsArgWith(1, null, @user = {holdingAccount:false})
 				@handler.registerNewUser @passingRequest, (err, user)=>
-					console.log err, user
 					err.should.deep.equal new Error("EmailAlreadyRegistered")
 					user.should.deep.equal @user
 					done()