Explorar el Código

Don't refresh resolved comments every times an entry changes

James Allen hace 9 años
padre
commit
5fb54d8447

+ 6 - 5
services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee

@@ -163,11 +163,12 @@ define [
 
 		$scope.refreshResolvedCommentsDropdown = () ->
 			$scope.reviewPanel.dropdown.loading = true
-			refreshRanges()
-				.then () ->
-					$scope.reviewPanel.dropdown.loading = false
-				.catch () ->
-					$scope.reviewPanel.dropdown.loading = false
+			q = refreshRanges()
+			q.then () ->
+				$scope.reviewPanel.dropdown.loading = false
+			q.catch () ->
+				$scope.reviewPanel.dropdown.loading = false
+			return q
 
 		updateEntries = (doc_id) ->
 			rangesTracker = getChangeTracker(doc_id)

+ 1 - 2
services/web/public/coffee/ide/review-panel/directives/resolvedCommentsDropdown.coffee

@@ -23,6 +23,7 @@ define [
 				scope.state.isOpen = !scope.state.isOpen
 				if (scope.state.isOpen)
 					scope.onOpen()
+						.then () -> filterResolvedComments()
 
 			scope.resolvedComments = []
 
@@ -54,5 +55,3 @@ define [
 							resolvedComment.docName = getDocNameById(docId)
 
 							scope.resolvedComments.push(resolvedComment)
-
-			scope.$on "entries:changed", filterResolvedComments