Ver código fonte

Prevent user from trying to delete archived project they don't own

This change disables the select-project checkbox if the user
is on the 'archived' project pane and they don't own the project.
The request to delete would fail anyway, but this prevents UI confusion
Shane Kilkelly 8 anos atrás
pai
commit
603252f3b4

+ 1 - 0
services/web/app/views/project/list/item.pug

@@ -2,6 +2,7 @@
 	input.select-item(
 		select-individual,
 		type="checkbox",
+		ng-disabled="shouldDisableCheckbox(project)",
 		ng-model="project.selected"
 		stop-propagation="click"
 		aria-label=translate('select_project') + " '{{ project.name }}'"

+ 3 - 0
services/web/public/coffee/main/project-list/project-list.coffee

@@ -462,6 +462,9 @@ define [
 
 	App.controller "ProjectListItemController", ($scope) ->
 
+		$scope.shouldDisableCheckbox = (project) ->
+			$scope.filter == 'archived' && project.accessLevel != 'owner'
+
 		$scope.projectLink = (project) ->
 			if project.accessLevel == 'readAndWrite' and project.source == 'token'
 				"/#{project.tokens.readAndWrite}"