Просмотр исходного кода

Merge pull request #24856 from overleaf/bg-history-redis-buffer-tweaks

fix error logging for chunk cache mismatches

GitOrigin-RevId: 85344c4025fdaa6ee916c5438ff38c7c49f4bce3
Brian Gough 1 год назад
Родитель
Сommit
62c8af2a93
1 измененных файлов с 16 добавлено и 1 удалено
  1. 16 1
      services/history-v1/storage/lib/chunk_store/redis.js

+ 16 - 1
services/history-v1/storage/lib/chunk_store/redis.js

@@ -172,7 +172,22 @@ function compareChunks(projectId, cachedChunk, currentChunk) {
     return false
     return false
   }
   }
   const identical = JSON.stringify(cachedChunk) === JSON.stringify(currentChunk)
   const identical = JSON.stringify(cachedChunk) === JSON.stringify(currentChunk)
-  logger.error({ projectId }, 'chunk cache mismatch')
+  if (!identical) {
+    try {
+      logger.error(
+        {
+          projectId,
+          cachedChunkStartVersion: cachedChunk.getStartVersion(),
+          cachedChunkEndVersion: cachedChunk.getEndVersion(),
+          currentChunkStartVersion: currentChunk.getStartVersion(),
+          currentChunkEndVersion: currentChunk.getEndVersion(),
+        },
+        'chunk cache mismatch'
+      )
+    } catch (err) {
+      // ignore errors while logging
+    }
+  }
   metrics.inc('chunk_store.redis.compare_chunks', 1, {
   metrics.inc('chunk_store.redis.compare_chunks', 1, {
     status: identical ? 'success' : 'fail',
     status: identical ? 'success' : 'fail',
   })
   })