Просмотр исходного кода

Merge pull request #2755 from overleaf/jpa-fix-race-in-references-boot

[frontend] ReferencesManager: fix a race condition with the socket boot

GitOrigin-RevId: cf21970bfc95128047d519b7c03ea0a29740174c
Eric Mc Sween 6 лет назад
Родитель
Сommit
674afe400d
1 измененных файлов с 4 добавлено и 12 удалено
  1. 4 12
      services/web/frontend/js/ide/references/ReferencesManager.js

+ 4 - 12
services/web/frontend/js/ide/references/ReferencesManager.js

@@ -49,20 +49,12 @@ define(['crypto-js/sha1'], function(CryptoJSSHA1) {
         // not on every reconnect
         if (!this.inited) {
           this.inited = true
-          return this.indexAllReferences(false)
+          this.ide.socket.on('references:keys:updated', keys =>
+            this._storeReferencesKeys(keys)
+          )
+          this.indexAllReferences(false)
         }
       })
-
-      setTimeout(
-        self =>
-          self.ide.socket.on('references:keys:updated', keys =>
-            // console.log '>> got keys from socket'
-            self._storeReferencesKeys(keys)
-          ),
-
-        1000,
-        this
-      )
     }
 
     _storeReferencesKeys(newKeys) {