Sfoglia il codice sorgente

Merge pull request #22082 from overleaf/mf-remove-is-split-test-active

[web] Remove `isSplitTestActive` function since it is no longer used

GitOrigin-RevId: 81f3f61f14bb10d403fa72a61dc4a304c191512f
M Fahru 1 anno fa
parent
commit
6daf2bef45

+ 0 - 11
services/web/app/src/Features/SplitTests/SplitTestHandler.js

@@ -582,16 +582,6 @@ async function _getSplitTest(name) {
   }
 }
 
-async function isSplitTestActive(splitTestName) {
-  try {
-    const splitTest = await _getSplitTest(splitTestName)
-    const currentVersion = SplitTestUtils.getCurrentVersion(splitTest)
-    return currentVersion?.active
-  } catch (e) {
-    logger.log('unable to check if split test is active ', splitTestName)
-  }
-}
-
 module.exports = {
   getPercentile,
   getAssignment: callbackify(getAssignment),
@@ -607,6 +597,5 @@ module.exports = {
     getAssignmentForUser,
     getOneTimeAssignment,
     getActiveAssignmentsForUser,
-    isSplitTestActive,
   },
 }

+ 0 - 26
services/web/test/unit/src/SplitTests/SplitTestHandlerTests.js

@@ -311,32 +311,6 @@ describe('SplitTestHandler', function () {
       )
     })
   })
-
-  describe('isSplitTestActive', function () {
-    it('returns false when current version is not active', async function () {
-      const res =
-        await this.SplitTestHandler.promises.isSplitTestActive(
-          'not-active-test'
-        )
-      expect(res).to.be.false
-    })
-    it('returns undefined false when current version is active', async function () {
-      const res =
-        await this.SplitTestHandler.promises.isSplitTestActive('active-test')
-      expect(res).to.be.true
-    })
-    it('returns undefined when there is an error checking', async function () {
-      this.SplitTestCache.get.rejects(new Error('oops'))
-      const res =
-        await this.SplitTestHandler.promises.isSplitTestActive('active-test')
-      expect(res).to.be.undefined
-    })
-    it('returns undefined when there is no test', async function () {
-      const res =
-        await this.SplitTestHandler.promises.isSplitTestActive('not-a-test')
-      expect(res).to.be.undefined
-    })
-  })
 })
 
 function makeSplitTest(