Explorar o código

Merge pull request #24024 from overleaf/ae-react-refresh-enabled

Use process.env.REACT_REFRESH_ENABLED for configuration

GitOrigin-RevId: e97967e52bed10422b0e2cce53fb09e2745a5c4a
Mathias Jakobsen hai 1 ano
pai
achega
6f826c5546
Modificáronse 2 ficheiros con 10 adicións e 10 borrados
  1. 8 9
      services/web/webpack.config.dev.js
  2. 2 1
      services/web/webpack.config.js

+ 8 - 9
services/web/webpack.config.dev.js

@@ -3,8 +3,6 @@ const { merge } = require('webpack-merge')
 const MiniCssExtractPlugin = require('mini-css-extract-plugin')
 const ReactRefreshWebpackPlugin = require('@pmmmwh/react-refresh-webpack-plugin')
 
-process.env.REACT_REFRESH = '1'
-
 const base = require('./webpack.config')
 
 // if WEBPACK_ENTRYPOINTS is defined, remove any entrypoints that aren't included
@@ -57,13 +55,14 @@ module.exports = merge(base, {
       filename: 'stylesheets/[name].css',
     }),
 
-    new ReactRefreshWebpackPlugin({
-      exclude: [
-        /node_modules/, // default
-        /source-editor/, // avoid crashing the source editor
-      ],
-      overlay: false,
-    }),
+    process.env.REACT_REFRESH_ENABLED === 'true' &&
+      new ReactRefreshWebpackPlugin({
+        exclude: [
+          /node_modules/, // default
+          /source-editor/, // avoid crashing the source editor
+        ],
+        overlay: false,
+      }),
 
     // Disable React DevTools if DISABLE_REACT_DEVTOOLS is set to "true"
     process.env.DISABLE_REACT_DEVTOOLS === 'true' &&

+ 2 - 1
services/web/webpack.config.js

@@ -143,7 +143,8 @@ module.exports = {
               cacheDirectory: true,
               configFile: path.join(__dirname, './babel.config.json'),
               plugins: [
-                process.env.REACT_REFRESH && 'react-refresh/babel',
+                process.env.REACT_REFRESH_ENABLED === 'true' &&
+                  'react-refresh/babel',
               ].filter(Boolean),
             },
           },