Przeglądaj źródła

Revert "Prepare new Pdf Preview rollout (#5664)" (#5745)

This reverts commit 047a3c636e09e9786c2a9b93514fef5bc46b0da9.

GitOrigin-RevId: 91b3c024cd364c1fd55d5e4fc6a2c592b784bc2a
Miguel Serrano 4 lat temu
rodzic
commit
739ac96195

+ 1 - 4
services/web/app/src/Features/Helpers/NewLogsUI.js

@@ -38,7 +38,6 @@ function _getVariantForPercentile(percentile) {
   }
 }
 
-// eslint-disable-next-line no-unused-vars
 function getNewLogsUIVariantForUser(user) {
   const { _id: userId, alphaProgram: isAlphaUser } = user
   const isSaaS = Boolean(Settings.overleaf)
@@ -57,7 +56,5 @@ function getNewLogsUIVariantForUser(user) {
 }
 
 module.exports = {
-  // We're disabling the split tests while rolling out the PDF Preview
-  // https://github.com/overleaf/internal/issues/5553
-  getNewLogsUIVariantForUser: () => EXISTING_UI,
+  getNewLogsUIVariantForUser,
 }

+ 1 - 20
services/web/app/src/Features/Project/ProjectController.js

@@ -733,27 +733,8 @@ const ProjectController = {
             }
           )
         },
-        newPdfPreviewAssignment(cb) {
-          SplitTestV2Handler.getAssignmentForSession(
-            req.session,
-            'new-pdf-preview',
-            (err, assignment) => {
-              cb(err, assignment)
-            }
-          )
-        },
       },
-      (
-        err,
-        {
-          project,
-          user,
-          subscription,
-          isTokenMember,
-          brandVariation,
-          newPdfPreviewAssignment,
-        }
-      ) => {
+      (err, { project, user, subscription, isTokenMember, brandVariation }) => {
         if (err != null) {
           OError.tag(err, 'error getting details for project page')
           return next(err)

+ 0 - 5
services/web/test/unit/src/HelperFiles/NewLogsUITests.js

@@ -9,11 +9,6 @@ const MODULE_PATH = require('path').join(
 describe('NewLogsUI helper', function () {
   let NewLogsUI
 
-  before(function () {
-    // We're disabling the Logs UI split test while rolling out the PDF Preview
-    this.skip()
-  })
-
   function userIdFromTime(time) {
     return ObjectId.createFromTime(time).toString()
   }

+ 0 - 3
services/web/test/unit/src/Project/ProjectControllerTests.js

@@ -139,9 +139,6 @@ describe('ProjectController', function () {
         getAssignment: sinon.stub().resolves({ active: false }),
         assignInLocalsContext: sinon.stub().resolves(),
       },
-      getAssignmentForSession: sinon
-        .stub()
-        .yields(null, { variant: 'variant' }),
       getAssignment: sinon.stub().yields(null, { active: false }),
       assignInLocalsContext: sinon.stub().yields(null),
     }