Explorar el Código

Merge pull request #3768 from overleaf/jpa-xss-10

[views] mitigate Angular XSS on password reset page

GitOrigin-RevId: 65f423fcb1a3afff0f396bb8e173d1e1bcff056a
Jakob Ackermann hace 5 años
padre
commit
7609b741fa
Se han modificado 1 ficheros con 3 adiciones y 2 borrados
  1. 3 2
      services/web/app/views/user/setPassword.pug

+ 3 - 2
services/web/app/views/user/setPassword.pug

@@ -17,7 +17,7 @@ block content
 						)
 						)
 							input(type="hidden", name="_csrf", value=csrfToken)
 							input(type="hidden", name="_csrf", value=csrfToken)
 							.alert.alert-success(ng-show="passwordResetForm.response.success")
 							.alert.alert-success(ng-show="passwordResetForm.response.success")
-								| #{translate("password_has_been_reset")}. 
+								| #{translate("password_has_been_reset")}.
 								a(href='/login') #{translate("login_here")}
 								a(href='/login') #{translate("login_here")}
 							div(ng-show="passwordResetForm.response.error == true")
 							div(ng-show="passwordResetForm.response.error == true")
 								div(ng-switch="passwordResetForm.response.status")
 								div(ng-switch="passwordResetForm.response.status")
@@ -42,11 +42,12 @@ block content
 									autofocus,
 									autofocus,
 									complex-password
 									complex-password
 								)
 								)
-								span.small.text-primary(ng-show="passwordResetForm.password.$error.complexPassword", ng-bind-html="complexPasswordErrorMessage") 
+								span.small.text-primary(ng-show="passwordResetForm.password.$error.complexPassword", ng-bind-html="complexPasswordErrorMessage")
 								input(
 								input(
 									type="hidden",
 									type="hidden",
 									name="passwordResetToken",
 									name="passwordResetToken",
 									value=passwordResetToken
 									value=passwordResetToken
+									ng-non-bindable
 								)
 								)
 							.actions
 							.actions
 								button.btn.btn-primary(
 								button.btn.btn-primary(