Просмотр исходного кода

Use a single entry for bulk actions.

Paulo Reis 9 лет назад
Родитель
Сommit
76ea497b33

+ 2 - 4
services/web/app/views/project/editor/review-panel.pug

@@ -82,10 +82,8 @@
 						on-submit="submitNewComment(content);"
 						on-submit="submitNewComment(content);"
 						on-cancel="cancelNewComment();"
 						on-cancel="cancelNewComment();"
 					)
 					)
-				div(ng-if="entry.type === 'bulk-accept'")
-					| Bulk accept
-				div(ng-if="entry.type === 'bulk-reject'")
-					| Bulk reject
+				div(ng-if="entry.type === 'bulk-actions'")
+					| Bulk actions.
 
 
 	.rp-entry-list(
 	.rp-entry-list(
 		ng-if="reviewPanel.subView === SubViews.OVERVIEW"
 		ng-if="reviewPanel.subView === SubViews.OVERVIEW"

+ 5 - 11
services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee

@@ -159,7 +159,7 @@ define [
 			entries = $scope.reviewPanel.entries[$scope.editor.open_doc_id] or {}
 			entries = $scope.reviewPanel.entries[$scope.editor.open_doc_id] or {}
 			permEntries = {}
 			permEntries = {}
 			for entry, entryData of entries
 			for entry, entryData of entries
-				if entry not in [ "add-comment", "bulk-accept", "bulk-reject" ]
+				if entry not in [ "add-comment", "bulk-actions" ]
 					permEntries[entry] = entryData 
 					permEntries[entry] = entryData 
 			Object.keys(permEntries).length
 			Object.keys(permEntries).length
 		), (nEntries) ->
 		), (nEntries) ->
@@ -285,8 +285,7 @@ define [
 			entries = getDocEntries(doc_id)
 			entries = getDocEntries(doc_id)
 
 
 			delete entries["add-comment"]
 			delete entries["add-comment"]
-			delete entries["bulk-accept"]
-			delete entries["bulk-reject"]
+			delete entries["bulk-actions"]
 
 
 			if selection
 			if selection
 				entries["add-comment"] = {
 				entries["add-comment"] = {
@@ -294,13 +293,8 @@ define [
 					offset: selection_offset_start
 					offset: selection_offset_start
 					length: selection_offset_end - selection_offset_start
 					length: selection_offset_end - selection_offset_start
 				}
 				}
-				entries["bulk-accept"] = {
-					type: "bulk-accept"
-					offset: selection_offset_start
-					length: selection_offset_end - selection_offset_start
-				}
-				entries["bulk-reject"] = {
-					type: "bulk-reject"
+				entries["bulk-actions"] = {
+					type: "bulk-actions"
 					offset: selection_offset_start
 					offset: selection_offset_start
 					length: selection_offset_end - selection_offset_start
 					length: selection_offset_end - selection_offset_start
 				}
 				}
@@ -312,7 +306,7 @@ define [
 					entry.focused = (entry.offset <= selection_offset_start <= entry.offset + entry.content.length)
 					entry.focused = (entry.offset <= selection_offset_start <= entry.offset + entry.content.length)
 				else if entry.type == "delete"
 				else if entry.type == "delete"
 					entry.focused = (entry.offset == selection_offset_start)
 					entry.focused = (entry.offset == selection_offset_start)
-				else if entry.type in [ "add-comment", "bulk-accept", "bulk-reject" ] and selection
+				else if entry.type in [ "add-comment", "bulk-actions" ] and selection
 					entry.focused = true
 					entry.focused = true
 			
 			
 			$scope.$broadcast "review-panel:recalculate-screen-positions"
 			$scope.$broadcast "review-panel:recalculate-screen-positions"