Browse Source

Switch order of args

Alasdair Smith 9 years ago
parent
commit
790b9ea8ed
1 changed files with 10 additions and 13 deletions
  1. 10 13
      services/real-time/app/coffee/Router.coffee

+ 10 - 13
services/real-time/app/coffee/Router.coffee

@@ -79,26 +79,23 @@ module.exports = Router =
 					if err?
 					if err?
 						Router._handleError null, err, client, "leaveProject"
 						Router._handleError null, err, client, "leaveProject"
 
 
-			# Variadic. The possible options:
+			# Variadic. The possible arguments:
 			# doc_id, callback
 			# doc_id, callback
 			# doc_id, fromVersion, callback
 			# doc_id, fromVersion, callback
 			# doc_id, options, callback
 			# doc_id, options, callback
-			# doc_id, options, fromVersion, callback
-			client.on "joinDoc", (doc_id, options, fromVersion, callback) ->
-				# options is optional
-				if typeof options == "function"
-					options = {}
-					callback = options
+			# doc_id, fromVersion, options, callback
+			client.on "joinDoc", (doc_id, fromVersion, options, callback) ->
+				if typeof fromVersion == "function"
 					fromVersion = -1
 					fromVersion = -1
-				else if typeof options == "number"
 					options = {}
 					options = {}
-					fromVersion = options
-					callback = fromVersion
-
-				# fromVersion is optional
-				if typeof fromVersion == "function"
 					callback = fromVersion
 					callback = fromVersion
+				else if typeof fromVersion == "object"
 					fromVersion = -1
 					fromVersion = -1
+					options = fromVersion
+					callback = options
+				if typeof options == "function"
+					options = {}
+					callback = options
 
 
 				WebsocketController.joinDoc client, doc_id, options, fromVersion, (err, args...) ->
 				WebsocketController.joinDoc client, doc_id, options, fromVersion, (err, args...) ->
 					if err?
 					if err?