Просмотр исходного кода

Merge pull request #17392 from overleaf/rh-friendly-readonly

Don't show 'add comment' button if isRestrictedTokenMember

GitOrigin-RevId: da236a4f2fbe0e66a7e5999bd70f7145fd60df20
roo hutton 2 лет назад
Родитель
Сommit
790fc5513b

+ 7 - 1
services/web/frontend/js/features/source-editor/components/review-panel/current-file-container.tsx

@@ -10,6 +10,7 @@ import AddCommentEntry from './entries/add-comment-entry'
 import BulkActionsEntry from './entries/bulk-actions-entry/bulk-actions-entry'
 import BulkActionsEntry from './entries/bulk-actions-entry/bulk-actions-entry'
 import PositionedEntries from './positioned-entries'
 import PositionedEntries from './positioned-entries'
 import { useReviewPanelValueContext } from '../../context/review-panel/review-panel-context'
 import { useReviewPanelValueContext } from '../../context/review-panel/review-panel-context'
+import { useEditorContext } from '../../../../shared/context/editor-context'
 import useCodeMirrorContentHeight from '../../hooks/use-codemirror-content-height'
 import useCodeMirrorContentHeight from '../../hooks/use-codemirror-content-height'
 import { ReviewPanelEntry } from '../../../../../../types/review-panel/entry'
 import { ReviewPanelEntry } from '../../../../../../types/review-panel/entry'
 import {
 import {
@@ -32,6 +33,7 @@ function CurrentFileContainer() {
     nVisibleSelectedChanges: nChanges,
     nVisibleSelectedChanges: nChanges,
   } = useReviewPanelValueContext()
   } = useReviewPanelValueContext()
   const contentHeight = useCodeMirrorContentHeight()
   const contentHeight = useCodeMirrorContentHeight()
+  const { isRestrictedTokenMember } = useEditorContext()
 
 
   const currentDocEntries =
   const currentDocEntries =
     openDocId && openDocId in entries ? entries[openDocId] : undefined
     openDocId && openDocId in entries ? entries[openDocId] : undefined
@@ -123,7 +125,11 @@ function CurrentFileContainer() {
                 )
                 )
               }
               }
 
 
-              if (entry.type === 'add-comment' && permissions.comment) {
+              if (
+                entry.type === 'add-comment' &&
+                permissions.comment &&
+                !isRestrictedTokenMember
+              ) {
                 return <AddCommentEntry key={id} />
                 return <AddCommentEntry key={id} />
               }
               }
 
 

+ 3 - 0
services/web/frontend/js/features/source-editor/components/review-panel/editor-widgets/editor-widgets.tsx

@@ -9,6 +9,7 @@ import {
   useReviewPanelValueContext,
   useReviewPanelValueContext,
 } from '../../../context/review-panel/review-panel-context'
 } from '../../../context/review-panel/review-panel-context'
 import { useIdeContext } from '@/shared/context/ide-context'
 import { useIdeContext } from '@/shared/context/ide-context'
+import { useEditorContext } from '@/shared/context/editor-context'
 import { useCodeMirrorViewContext } from '../../codemirror-editor'
 import { useCodeMirrorViewContext } from '../../codemirror-editor'
 import Modal, { useBulkActionsModal } from '../entries/bulk-actions-entry/modal'
 import Modal, { useBulkActionsModal } from '../entries/bulk-actions-entry/modal'
 import getMeta from '../../../../../utils/meta'
 import getMeta from '../../../../../utils/meta'
@@ -38,6 +39,7 @@ function EditorWidgets() {
     )
     )
   const view = useCodeMirrorViewContext()
   const view = useCodeMirrorViewContext()
   const { reviewPanelOpen } = useLayoutContext()
   const { reviewPanelOpen } = useLayoutContext()
+  const { isRestrictedTokenMember } = useEditorContext()
 
 
   const {
   const {
     entries,
     entries,
@@ -99,6 +101,7 @@ function EditorWidgets() {
           )}
           )}
           {hasTrackChangesFeature &&
           {hasTrackChangesFeature &&
             permissions.comment &&
             permissions.comment &&
+            !isRestrictedTokenMember &&
             currentDocEntries?.['add-comment'] && (
             currentDocEntries?.['add-comment'] && (
               <AddCommentButton onClick={handleAddNewCommentClick}>
               <AddCommentButton onClick={handleAddNewCommentClick}>
                 <Icon type="comment" /> {t('add_comment')}
                 <Icon type="comment" /> {t('add_comment')}