فهرست منبع

Use meta tags for user info and refactor syntax for conditional classes (#26617)

* Use meta tags for user info data

* Remove Back button

* Refactor syntax for conditional classes

* Inline meta tags

* Keep "Please go back and try again" text

* Shorthand classname

GitOrigin-RevId: 3b78bff04b4fb8dc7fdecf5b663d2a4f64c3218b
Rebeka Dekany 1 سال پیش
والد
کامیت
79e5a884f5

+ 2 - 2
services/web/app/views/_mixins/begin_now_card.pug

@@ -17,7 +17,7 @@ mixin begin_now_card
 				p.card-links
 				p.card-links
 					if !isUserLoggedIn
 					if !isUserLoggedIn
 						a.btn.btn-primary.card-link(href=registerURL) #{translate("sign_up_for_free")}
 						a.btn.btn-primary.card-link(href=registerURL) #{translate("sign_up_for_free")}
-					a.btn.card-link(
-						class=isUserLoggedIn ? 'btn-primary' : 'btn-secondary'
+					a.card-link(
 						href=plansURL
 						href=plansURL
+						class={'btn-primary': isUserLoggedIn, 'btn-secondary': !isUserLoggedIn}
 					) #{translate("explore_all_plans")}
 					) #{translate("explore_all_plans")}

+ 1 - 1
services/web/app/views/_mixins/bookmarkable_tabset.pug

@@ -2,7 +2,7 @@ mixin bookmarkable-tabset-header(id, title, active)
 	li(role='presentation')
 	li(role='presentation')
 		a.nav-link(
 		a.nav-link(
 			href='#' + id
 			href='#' + id
-			class=active ? 'active' : ''
+			class={active}
 			aria-controls=id
 			aria-controls=id
 			role='tab'
 			role='tab'
 			data-toggle='tab'
 			data-toggle='tab'

+ 10 - 22
services/web/app/views/_mixins/links.pug

@@ -1,29 +1,23 @@
 include ./material_symbol
 include ./material_symbol
 
 
 mixin linkBenefits(linkText, linkClass)
 mixin linkBenefits(linkText, linkClass)
-	a(
-		href=(settings.siteUrl ? settings.siteUrl : '') + '/for/authors'
-		class=linkClass ? linkClass : ''
-	)
+	a(href=(settings.siteUrl ? settings.siteUrl : '') + '/for/authors' class=linkClass)
 		| #{linkText ? linkText : 'benefits'}
 		| #{linkText ? linkText : 'benefits'}
 
 
 mixin linkBlog(linkText, linkClass, slug)
 mixin linkBlog(linkText, linkClass, slug)
 	if slug
 	if slug
 		a(
 		a(
 			href=(settings.siteUrl ? settings.siteUrl : '') + '/blog/' + slug
 			href=(settings.siteUrl ? settings.siteUrl : '') + '/blog/' + slug
-			class=linkClass ? linkClass : ''
+			class=linkClass
 		)
 		)
 			| #{linkText ? linkText : 'blog'}
 			| #{linkText ? linkText : 'blog'}
 
 
 mixin linkContact(linkText, linkClass)
 mixin linkContact(linkText, linkClass)
-	a(
-		href=(settings.siteUrl ? settings.siteUrl : '') + '/contact'
-		class=linkClass ? linkClass : ''
-	)
+	a(href=(settings.siteUrl ? settings.siteUrl : '') + '/contact' class=linkClass)
 		| #{linkText ? linkText : 'contact'}
 		| #{linkText ? linkText : 'contact'}
 
 
 mixin linkDash(linkText, linkClass)
 mixin linkDash(linkText, linkClass)
-	a(href='/project' class=linkClass ? linkClass : '')
+	a(href='/project' class=linkClass)
 		| #{linkText ? linkText : 'project dashboard'}
 		| #{linkText ? linkText : 'project dashboard'}
 
 
 mixin linkInvite(linkText, linkClass, track)
 mixin linkInvite(linkText, linkClass, track)
@@ -36,7 +30,7 @@ mixin linkInvite(linkText, linkClass, track)
 
 
 	a(
 	a(
 		href='/user/bonus'
 		href='/user/bonus'
-		class=linkClass ? linkClass : ''
+		class=linkClass
 		event-tracking-ga=gaCategory
 		event-tracking-ga=gaCategory
 		event-tracking=gaAction
 		event-tracking=gaAction
 		event-tracking-label=gaLabel
 		event-tracking-label=gaLabel
@@ -47,7 +41,7 @@ mixin linkInvite(linkText, linkClass, track)
 		span #{linkText ? linkText : 'invite your friends'}
 		span #{linkText ? linkText : 'invite your friends'}
 
 
 mixin linkPlansAndPricing(linkText, linkClass)
 mixin linkPlansAndPricing(linkText, linkClass)
-	a(href='/user/subscription/plans' class=linkClass ? linkClass : '')
+	a(href='/user/subscription/plans' class=linkClass)
 		| #{linkText ? linkText : 'plans and pricing'}
 		| #{linkText ? linkText : 'plans and pricing'}
 
 
 mixin linkPrintNewTab(linkText, linkClass, icon, track)
 mixin linkPrintNewTab(linkText, linkClass, icon, track)
@@ -60,7 +54,7 @@ mixin linkPrintNewTab(linkText, linkClass, icon, track)
 
 
 	a(
 	a(
 		href='?media=print'
 		href='?media=print'
-		class=linkClass ? linkClass : ''
+		class=linkClass
 		event-tracking-ga=gaCategory
 		event-tracking-ga=gaCategory
 		event-tracking=gaAction
 		event-tracking=gaAction
 		event-tracking-label=gaLabel
 		event-tracking-label=gaLabel
@@ -76,17 +70,11 @@ mixin linkPrintNewTab(linkText, linkClass, icon, track)
 		span #{linkText ? linkText : 'print'}
 		span #{linkText ? linkText : 'print'}
 
 
 mixin linkSignIn(linkText, linkClass, redirect)
 mixin linkSignIn(linkText, linkClass, redirect)
-	a(
-		href=`/login${redirect ? '?redir=' + redirect : ''}`
-		class=linkClass ? linkClass : ''
-	)
+	a(href=`/login${redirect ? '?redir=' + redirect : ''}` class=linkClass)
 		| #{linkText ? linkText : 'sign in'}
 		| #{linkText ? linkText : 'sign in'}
 
 
 mixin linkSignUp(linkText, linkClass, redirect)
 mixin linkSignUp(linkText, linkClass, redirect)
-	a(
-		href=`/register${redirect ? '?redir=' + redirect : ''}`
-		class=linkClass ? linkClass : ''
-	)
+	a(href=`/register${redirect ? '?redir=' + redirect : ''}` class=linkClass)
 		| #{linkText ? linkText : 'sign up'}
 		| #{linkText ? linkText : 'sign up'}
 
 
 mixin linkTweet(linkText, linkClass, tweetText, track)
 mixin linkTweet(linkText, linkClass, tweetText, track)
@@ -113,7 +101,7 @@ mixin linkTweet(linkText, linkClass, tweetText, track)
 mixin linkUniversities(linkText, linkClass)
 mixin linkUniversities(linkText, linkClass)
 	a(
 	a(
 		href=(settings.siteUrl ? settings.siteUrl : '') + '/for/universities'
 		href=(settings.siteUrl ? settings.siteUrl : '') + '/for/universities'
-		class=linkClass ? linkClass : ''
+		class=linkClass
 	)
 	)
 		| #{linkText ? linkText : 'universities'}
 		| #{linkText ? linkText : 'universities'}
 
 

+ 1 - 2
services/web/app/views/general/400.pug

@@ -25,5 +25,4 @@ block body
 							a(href='mailto:' + settings.adminEmail target='_blank') #{settings.adminEmail}
 							a(href='mailto:' + settings.adminEmail target='_blank') #{settings.adminEmail}
 							| .
 							| .
 						p.error-actions
 						p.error-actions
-							a.error-btn(href='javascript:history.back()') Back
-							a.btn.btn-secondary(href='/') Home
+							a.btn.btn-primary(href='/') Home

+ 1 - 1
services/web/app/views/layout/fat-footer-website-redesign.pug

@@ -3,7 +3,7 @@ footer.fat-footer.hidden-print.website-redesign-fat-footer
 		role='navigation'
 		role='navigation'
 		aria-label=translate('footer_navigation')
 		aria-label=translate('footer_navigation')
 	)
 	)
-		.fat-footer-sections(class=hideFatFooter ? 'hidden' : undefined)
+		.fat-footer-sections(class={hidden: hideFatFooter})
 			#footer-brand.footer-section
 			#footer-brand.footer-section
 				a.footer-brand(href='/' aria-label=settings.appName)
 				a.footer-brand(href='/' aria-label=settings.appName)
 
 

+ 1 - 1
services/web/app/views/layout/fat-footer.pug

@@ -3,7 +3,7 @@ footer.fat-footer.hidden-print
 		role='navigation'
 		role='navigation'
 		aria-label=translate('footer_navigation')
 		aria-label=translate('footer_navigation')
 	)
 	)
-		.fat-footer-sections(class=hideFatFooter ? 'hidden' : undefined)
+		.fat-footer-sections(class={hidden: hideFatFooter})
 			#footer-brand.footer-section
 			#footer-brand.footer-section
 				a.footer-brand(href='/' aria-label=settings.appName)
 				a.footer-brand(href='/' aria-label=settings.appName)
 
 

+ 1 - 1
services/web/app/views/layout/language-picker-bootstrap-5.pug

@@ -27,7 +27,7 @@ li.dropdown.dropup.subdued.language-picker(dropdown)
 					a.menu-indent(
 					a.menu-indent(
 						href=subdomainDetails.url + currentUrlWithQueryParams
 						href=subdomainDetails.url + currentUrlWithQueryParams
 						role='menuitem'
 						role='menuitem'
-						class=isActive ? 'dropdown-item active' : 'dropdown-item'
+						class=['dropdown-item', {active: isActive}]
 						aria-selected=isActive ? 'true' : 'false'
 						aria-selected=isActive ? 'true' : 'false'
 					)
 					)
 						| #{settings.translatedLanguages[subdomainDetails.lngCode]}
 						| #{settings.translatedLanguages[subdomainDetails.lngCode]}