Jelajahi Sumber

Merge pull request #14968 from overleaf/rd-report-footer-heading

Accessibility - Semantic heading markup for footer titles

GitOrigin-RevId: e534835ba2ad21e91bd396120444ee05fcc02c6a
Rebeka Dekany 3 tahun lalu
induk
melakukan
7b1a728e00

+ 5 - 5
services/web/app/views/layout/fat-footer.pug

@@ -7,7 +7,7 @@ footer.fat-footer.hidden-print
 				a(href='/', aria-label=settings.appName).footer-brand
 					
 			.footer-section
-				.footer-section-heading #{translate('About')}
+				h2.footer-section-heading #{translate('About')}
 					
 				ul.list-unstyled
 					li
@@ -22,7 +22,7 @@ footer.fat-footer.hidden-print
 						a(href="/blog") #{translate('blog')}
 						
 			.footer-section
-				.footer-section-heading #{translate('learn')}
+				h2.footer-section-heading #{translate('learn')}
 		
 				ul.list-unstyled
 					li
@@ -39,7 +39,7 @@ footer.fat-footer.hidden-print
 						a(href="/learn/latex/Tables") #{translate('how_to_create_tables')}
 						
 			.footer-section
-				.footer-section-heading !{translate('footer_plans_and_pricing')}
+				h2.footer-section-heading !{translate('footer_plans_and_pricing')}
 		
 				ul.list-unstyled
 					li
@@ -57,7 +57,7 @@ footer.fat-footer.hidden-print
 						a(href="/user/subscription/plans?itm_referrer=footer-for-students#view=student") #{translate('for_students')}
 						
 			.footer-section
-				.footer-section-heading #{translate('get_involved')}
+				h2.footer-section-heading #{translate('get_involved')}
 		
 				ul.list-unstyled
 					li
@@ -71,7 +71,7 @@ footer.fat-footer.hidden-print
 							a(href="/user/bonus") #{translate('refer_a_friend')}
 		
 			.footer-section
-				.footer-section-heading #{translate('help')}
+				h2.footer-section-heading #{translate('help')}
 		
 				ul.list-unstyled
 					li

+ 1 - 0
services/web/frontend/stylesheets/components/footer.less

@@ -86,6 +86,7 @@ footer.site-footer {
   }
 
   .footer-section-heading {
+    color: @neutral-20;
     font-family: @font-family-serif;
     font-size: @font-size-h3;
     line-height: @headings-line-height;