Просмотр исходного кода

Merge pull request #12870 from overleaf/td-history-prevent-diff-render-on-label-change

History migration: prevent unnecessary render when adding or deleting a label

GitOrigin-RevId: acabd581403f17f863e3bd0c06d1fbd77fe22228
Tim Down 3 лет назад
Родитель
Сommit
7f17992cbc

+ 4 - 3
services/web/frontend/js/features/history/context/history-context.tsx

@@ -187,12 +187,13 @@ function useHistory() {
     }
   }, [view, fetchNextBatchOfUpdates])
 
-  const { updateRange, comparing } = selection
+  const { updateRange, comparing, files } = selection
   const { updates } = updatesInfo
+  const filesEmpty = files.length === 0
 
   // Load files when the update selection changes
   useEffect(() => {
-    if (!updateRange) {
+    if (!updateRange || !filesEmpty) {
       return
     }
     const { fromV, toV } = updateRange
@@ -222,7 +223,7 @@ function useHistory() {
       .catch(error => {
         setError(error)
       })
-  }, [updateRange, projectId, updates, comparing, setError])
+  }, [updateRange, projectId, updates, comparing, setError, filesEmpty])
 
   useEffect(() => {
     // Set update range if there isn't one and updates have loaded