Просмотр исходного кода

Merge pull request #15597 from overleaf/td-ide-page-preview-pdf-fix

Remove FileTreeManager from FileViewPdf

GitOrigin-RevId: ca58d8695ab8e8868f8025aab932d665742a4131
Tim Down 2 лет назад
Родитель
Сommit
8144d431a6
1 измененных файлов с 4 добавлено и 7 удалено
  1. 4 7
      services/web/frontend/js/features/file-view/components/file-view-pdf.tsx

+ 4 - 7
services/web/frontend/js/features/file-view/components/file-view-pdf.tsx

@@ -1,7 +1,6 @@
 import { FC, useCallback } from 'react'
 import { FC, useCallback } from 'react'
 import useIsMounted from '@/shared/hooks/use-is-mounted'
 import useIsMounted from '@/shared/hooks/use-is-mounted'
 import { useFileTreePathContext } from '@/features/file-tree/contexts/file-tree-path'
 import { useFileTreePathContext } from '@/features/file-tree/contexts/file-tree-path'
-import { useIdeContext } from '@/shared/context/ide-context'
 import { debugConsole } from '@/utils/debugging'
 import { debugConsole } from '@/utils/debugging'
 
 
 const FileViewPdf: FC<{
 const FileViewPdf: FC<{
@@ -11,8 +10,7 @@ const FileViewPdf: FC<{
 }> = ({ fileId, onLoad, onError }) => {
 }> = ({ fileId, onLoad, onError }) => {
   const mountedRef = useIsMounted()
   const mountedRef = useIsMounted()
 
 
-  const { fileTreeManager } = useIdeContext()
-  const { previewByPath } = useFileTreePathContext()
+  const { previewByPath, pathInFolder } = useFileTreePathContext()
 
 
   const handleContainer = useCallback(
   const handleContainer = useCallback(
     async (element: HTMLDivElement | null) => {
     async (element: HTMLDivElement | null) => {
@@ -27,9 +25,8 @@ const FileViewPdf: FC<{
           return
           return
         }
         }
 
 
-        const entity = fileTreeManager.findEntityById(fileId)
-        const path = fileTreeManager.getEntityPath(entity)
-        const preview = previewByPath(path)
+        const path = pathInFolder(fileId)
+        const preview = path ? previewByPath(path) : null
 
 
         if (!preview) {
         if (!preview) {
           onError()
           onError()
@@ -61,7 +58,7 @@ const FileViewPdf: FC<{
         }
         }
       }
       }
     },
     },
-    [fileTreeManager, mountedRef, previewByPath, fileId, onLoad, onError]
+    [mountedRef, pathInFolder, fileId, previewByPath, onLoad, onError]
   )
   )
 
 
   return <div className="file-view-pdf" ref={handleContainer} />
   return <div className="file-view-pdf" ref={handleContainer} />