Sfoglia il codice sorgente

Merge pull request #17099 from overleaf/mj-no-op-transform

[overleaf-editor-core] Fix transform for no-op Operation

GitOrigin-RevId: 20b8681153fb0788feb7d5d9954781a5432dbe69
Mathias Jakobsen 2 anni fa
parent
commit
826020effe

+ 1 - 1
libraries/overleaf-editor-core/lib/operation/index.js

@@ -160,7 +160,7 @@ class Operation {
    * @return {Operation[]} operations `[a', b']`
    */
   static transform(a, b) {
-    if (a.isNoOp() || b.isNoOp()) return [b, a]
+    if (a.isNoOp() || b.isNoOp()) return [a, b]
 
     function transpose(transformer) {
       return transformer(b, a).reverse()

+ 6 - 0
libraries/overleaf-editor-core/test/operation.test.js

@@ -741,4 +741,10 @@ describe('Operation', function () {
       .expectFiles({})
       .expectSymmetry()
   })
+
+  it('transforms no-op with other operation', function () {
+    runConcurrently(Operation.NO_OP, addFile('foo', 'test')).expectFiles({
+      foo: 'test',
+    })
+  })
 })