Просмотр исходного кода

Merge pull request #285 from sharelatex/file-path-checks

add file path check on element names
Henry Oswald 10 лет назад
Родитель
Сommit
8492ea7d28
1 измененных файлов с 5 добавлено и 0 удалено
  1. 5 0
      services/web/app/coffee/Features/Project/ProjectEntityHandler.coffee

+ 5 - 0
services/web/app/coffee/Features/Project/ProjectEntityHandler.coffee

@@ -512,6 +512,11 @@ module.exports = ProjectEntityHandler =
 			return callback(e)
 			return callback(e)
 		type = sanitizeTypeOfElement type
 		type = sanitizeTypeOfElement type
 
 
+		if path.resolve("/", element.name) isnt "/#{element.name}" or element.name.match("/")
+			e = new Error("invalid element name")
+			logger.err project_id:project._id, folder_id:folder_id, element:element, type:type, "failed trying to insert element as name was invalid"
+			return callback(e)
+
 		if !folder_id?
 		if !folder_id?
 			folder_id = project.rootFolder[0]._id
 			folder_id = project.rootFolder[0]._id
 		ProjectEntityHandler._countElements project, (err, count)->
 		ProjectEntityHandler._countElements project, (err, count)->