Просмотр исходного кода

Merge pull request #7278 from overleaf/jpa-block-track-changes-access

[web] block restricted token users from accessing track-changes details

GitOrigin-RevId: f2e734b48aaa1d1cae6d5db0e0312a78d42165de
Jakob Ackermann 4 лет назад
Родитель
Сommit
862ff734c6

+ 2 - 1
services/web/frontend/js/ide/editor/directives/aceEditor.js

@@ -664,12 +664,13 @@ App.directive(
         }
 
         const initTrackChanges = function () {
+          if (!trackChangesManager) return
+
           trackChangesManager.rangesTracker = scope.sharejsDoc.ranges
 
           // Force onChangeSession in order to set up highlights etc.
           trackChangesManager.onChangeSession()
 
-          if (!trackChangesManager) return
           editor.on('changeSelection', trackChangesManager.onChangeSelection)
 
           // Selection also moves with updates elsewhere in the document

+ 3 - 1
services/web/frontend/js/ide/review-panel/RangesTracker.js

@@ -247,7 +247,9 @@ export default RangesTracker = class RangesTracker {
       this.applyDeleteToChanges(op, metadata)
       return this.applyDeleteToComments(op)
     } else if (op.c != null) {
-      return this.addComment(op, metadata)
+      if (!window.isRestrictedTokenMember) {
+        return this.addComment(op, metadata)
+      }
     } else {
       throw new Error('unknown op type')
     }

+ 6 - 2
services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js

@@ -475,12 +475,16 @@ export default App.controller(
         }
 
         if ($scope.users[change.metadata.user_id] == null) {
-          refreshChangeUsers(change.metadata.user_id)
+          if (!window.isRestrictedTokenMember) {
+            refreshChangeUsers(change.metadata.user_id)
+          }
         }
       }
 
       if (rangesTracker.comments.length > 0) {
-        ensureThreadsAreLoaded()
+        if (!window.isRestrictedTokenMember) {
+          ensureThreadsAreLoaded()
+        }
       }
 
       for (const comment of Array.from(rangesTracker.comments)) {