Преглед изворни кода

Merge pull request #3003 from overleaf/jel-zotero-event

Add Google Analytics event for Zotero A/B test

GitOrigin-RevId: 2b97a6070828fb97ea741a6e355c20314f59faad
Jessica Lawshe пре 6 година
родитељ
комит
88057c4caa

+ 2 - 1
services/web/app/src/Features/Project/ProjectController.js

@@ -830,7 +830,8 @@ const ProjectController = {
               gitBridgePublicBaseUrl: Settings.gitBridgePublicBaseUrl,
               wsUrl,
               showSupport: Features.hasFeature('support'),
-              gaOptimize: enableOptimize
+              gaOptimize: enableOptimize,
+              customOptimizeEvent: true
             })
             timer.done()
           }

+ 4 - 2
services/web/app/views/layout.pug

@@ -42,8 +42,10 @@ html(
 			if gaOptimize === true && typeof(gaOptimizeId) != "undefined"
 				script(type='text/javascript').
 					ga('require', '#{gaOptimizeId}')
-					ga('send', 'event', 'pageview',  document.title.substring(0, 499), window.location.href.substring(0, 499))
-				if !experimentId
+				if !customOptimizeEvent
+					script(type='text/javascript').
+						ga('send', 'event', 'pageview',  document.title.substring(0, 499), window.location.href.substring(0, 499))
+				if !ExposedSettings.experimentId
 					//- Anti-flicker snippet
 					//- Only run for tests controlled by Optimize editor
 					style(type='text/css') .async-hide { opacity: 0 !important}