Explorar el Código

moved renameEntity from collab manager to editor controller

Henry Oswald hace 12 años
padre
commit
88e47bbe12

+ 11 - 0
services/web/app/coffee/Features/Editor/EditorController.coffee

@@ -242,6 +242,17 @@ module.exports = EditorController =
 		logger.log project_id:project_id, "recived message to delete project"
 		logger.log project_id:project_id, "recived message to delete project"
 		ProjectHandler.deleteProject project_id, callback
 		ProjectHandler.deleteProject project_id, callback
 
 
+	renameEntity: (project_id, entity_id, entityType, newName, callback)->
+		newName = sanitize.escape(newName)
+		Metrics.inc "editor.rename-entity"
+		logger.log entity_id:entity_id, entity_id:entity_id, entity_id:entity_id, "reciving new name for entity for project"
+		ProjectHandler.renameEntity project_id, entity_id, entityType, newName, =>
+			if newName.length > 0
+				EditorRealTimeController.emitToRoom project_id, 'reciveEntityRename', entity_id, newName
+				callback?()
+
+
+
 	p:
 	p:
 		notifyProjectUsersOfNewFolder: (project_id, folder_id, folder, callback = (error)->)->
 		notifyProjectUsersOfNewFolder: (project_id, folder_id, folder, callback = (error)->)->
 			logger.log project_id:project_id, folder:folder, parentFolder_id:folder_id, "sending newly created folder out to users"
 			logger.log project_id:project_id, folder:folder, parentFolder_id:folder_id, "sending newly created folder out to users"

+ 0 - 9
services/web/app/coffee/managers/CollaberationManager.coffee

@@ -15,15 +15,6 @@ EditorRealTimeController = require('../Features/Editor/EditorRealTimeController'
 module.exports = class CollaberationManager
 module.exports = class CollaberationManager
 	constructor: (@io)->
 	constructor: (@io)->
 
 
-	renameEntity: (project_id, entity_id, entityType, newName, callback)->
-		newName = sanitize.escape(newName)
-		metrics.inc "editor.rename-entity"
-		logger.log entity_id:entity_id, entity_id:entity_id, entity_id:entity_id, "reciving new name for entity for project"
-		projectHandler.renameEntity project_id, entity_id, entityType, newName, =>
-			if newName.length > 0
-				EditorRealTimeController.emitToRoom project_id, 'reciveEntityRename', entity_id, newName
-				callback?()
-
 	moveEntity: (project_id, entity_id, folder_id, entityType, callback)->
 	moveEntity: (project_id, entity_id, folder_id, entityType, callback)->
 		metrics.inc "editor.move-entity"
 		metrics.inc "editor.move-entity"
 		projectEntityHandler.moveEntity project_id, entity_id, folder_id, entityType, =>
 		projectEntityHandler.moveEntity project_id, entity_id, folder_id, entityType, =>

+ 1 - 1
services/web/app/coffee/router.coffee

@@ -291,7 +291,7 @@ module.exports = class Router
 
 
 			client.on 'renameEntity', (entity_id, entityType, newName, callback)->
 			client.on 'renameEntity', (entity_id, entityType, newName, callback)->
 				AuthorizationManager.ensureClientCanEditProject client, (error, project_id) =>
 				AuthorizationManager.ensureClientCanEditProject client, (error, project_id) =>
-					collaberationManager.renameEntity(project_id, entity_id, entityType, newName, callback)
+					EditorController.renameEntity(project_id, entity_id, entityType, newName, callback)
 
 
 			client.on 'moveEntity', (entity_id, folder_id, entityType, callback)->
 			client.on 'moveEntity', (entity_id, folder_id, entityType, callback)->
 				AuthorizationManager.ensureClientCanEditProject client, (error, project_id) =>
 				AuthorizationManager.ensureClientCanEditProject client, (error, project_id) =>

+ 22 - 0
services/web/test/UnitTests/coffee/Editor/EditorControllerTests.coffee

@@ -621,3 +621,25 @@ describe "EditorController", ->
 				@ProjectHandler::deleteProject.calledWith(@project_id).should.equal true
 				@ProjectHandler::deleteProject.calledWith(@project_id).should.equal true
 				done()
 				done()
 
 
+
+	describe "renameEntity", ->
+
+		beforeEach ->
+			@err = "errro"
+			@entity_id = "entity_id_here"
+			@entityType = "doc"
+			@newName = "bobsfile.tex"
+			@ProjectHandler::renameEntity = sinon.stub().callsArgWith(4, @err)
+			@EditorRealTimeController.emitToRoom = sinon.stub()
+
+		it "should call the project handler", (done)->
+			@EditorController.renameEntity @project_id, @entity_id, @entityType, @newName, =>
+				@ProjectHandler::renameEntity.calledWith(@project_id, @entity_id, @entityType, @newName).should.equal true
+				done()
+
+
+		it "should emit the update to the room", (done)->
+			@EditorController.renameEntity @project_id, @entity_id, @entityType, @newName, =>
+				@EditorRealTimeController.emitToRoom.calledWith(@project_id, 'reciveEntityRename', @entity_id, @newName).should.equal true				
+				done()
+