Przeglądaj źródła

avoid exception in validateProjectName

Brian Gough 9 lat temu
rodzic
commit
8cf3288187

+ 1 - 1
services/web/app/coffee/Features/Project/ProjectDetailsHandler.coffee

@@ -57,7 +57,7 @@ module.exports = ProjectDetailsHandler =
 
 	MAX_PROJECT_NAME_LENGTH: 150
 	validateProjectName: (name, callback = (error) ->) ->
-		if name.length == 0
+		if !name? or name.length == 0
 			return callback(new Errors.InvalidNameError("Project name cannot be blank"))
 		else if name.length > @MAX_PROJECT_NAME_LENGTH
 			return callback(new Errors.InvalidNameError("Project name is too long"))

+ 6 - 0
services/web/test/UnitTests/coffee/Project/ProjectDetailsHandlerTests.coffee

@@ -126,6 +126,12 @@ describe 'ProjectDetailsHandler', ->
 				done()
 
 	describe "validateProjectName", ->
+
+		it "should reject undefined names", (done) ->
+			@handler.validateProjectName undefined, (error) ->
+				expect(error).to.exist
+				done()
+
 		it "should reject empty names", (done) ->
 			@handler.validateProjectName "", (error) ->
 				expect(error).to.exist